[email protected]: promote to default python3 #150390

branchvincent · 2023-10-10T05:11:58Z

Have you followed the guidelines for contributing?
Have you ensured that your commits follow the commit style guide?
Have you checked that there aren't other open pull requests for the same formula update/change?
Have you built your formula locally with HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
Does your build pass brew audit --strict <formula> (after doing HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

Hopefully this is a smoother transition than last year since all formulae should now be using fully-qualified python binaries like python3.11

branchvincent · 2023-10-11T04:10:29Z

So far without Linux

bpytop: bpytop: migrate to [email protected] #151086
condure: seen before, will look into fixing this
pyqt@5: pyqt@5: migrate to [email protected] #150515
trino: known, https://github.com/trinodb/trino/issues/18983983

Bo98 · 2023-10-11T13:13:38Z

Might be worth revision bumping so the user doesn't end up in a scenario where they have Python 3.12 already installed but no python3.

Formula/p/[email protected]

github-actions · 2023-11-07T00:02:13Z

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

onlined · 2023-11-28T10:52:52Z

What is blocking this PR right now? I can lend a hand.

github-actions · 2023-12-19T13:57:30Z

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

nickserv · 2023-12-20T01:47:17Z

This appears to still be good.

github-actions · 2024-01-11T00:02:31Z

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

nickserv · 2024-01-13T03:12:51Z

This appears to still be good. I'm still not sure why we wouldn't want to migrate to the newest version, especially considering the typing improvements.

SMillerDev

Awaiting #150390 (comment)

cho-m · 2024-01-15T00:53:05Z

Awaiting #150390 (comment)

Which may also depend on #157500 if we decide to drop majority of python-* formulae.

github-actions · 2024-02-06T00:02:13Z

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

cho-m · 2024-02-20T13:06:02Z

Formula/p/[email protected]

-      tkinter is no longer included with this formula, but it is available separately:
-        brew install python-tk@#{version.major_minor}


Did we want to remove this caveat? There is also the python-gdbm caveat in [email protected] that didn't carry over to [email protected].

[email protected] and [email protected] will remain as they are part of base Python but we just put them into separate formulae (given that Homebrew doesn't support sub/split-packages).

Not important to handle here but may want to add caveats in follow up.

I agree that it makes sense to handle this in a followup syntax PR.

I removed that line because it now felt useless. We had it for a few years now I think. I hope our users have adjusted their workflows, and my hope was to stop telling obvious things in the caveats.
But if you think we need to add it back: this can be done in a syntax-only follow-up pull request.

It doesn't matter to me whether we keep or remove it.

Homebrew's way of separate formulae is a bit odd since we don't support sub/split-packages. Most repositories would either install everything together (e.g. Arch Linux) or use subpackages (which colocates the related packages that use the same source distribution).

cho-m · 2024-02-21T16:22:39Z

Failures that can be followed up on:

libcap-ng is probably installing Python bindings into $HOMEBREW_PREFIX/lib/... rather than #{lib}/... since we don't have a sandbox on Linux. This means it passes when built from source but will fail later on when installed from bottle.
profanity is building with python3-embed so Python feature is disabled on macOS and linked to [email protected] on Linux. May be worth adding a major-versioned symlink to libexec so we can use PKG_CONFIG_PATH rather than an inreplace workaround (or manually passing in corresponding python_CFLAGS/python_LIBS).

github-actions · 2024-02-21T17:00:12Z

@branchvincent has requested bottles to be published to this PR.

p-linnane · 2024-02-21T17:41:30Z

Thanks for all the work here @branchvincent!

branchvincent · 2024-02-21T19:21:11Z

And thanks @iMichka for all the doc updates!

relates to Homebrew/homebrew-core#150390 Signed-off-by: Rui Chen <[email protected]>

acc06bc ci, macos: Use `--break-system-packages` with Homebrew's python (Hennadii Stepanov) ae5f720 ci: Add workaround for Homebrew's python link error (Hennadii Stepanov) Pull request description: Homebrew [promoted](Homebrew/homebrew-core#150390) `[email protected]` to the default `python3`. Now, our "macOS native" CI job is facing the following issues: 1. Installing `qt@5` [requires](https://github.com/bitcoin/bitcoin/actions/runs/8216848118/job/22471875454#step:4:51) re-installing `[email protected]`: ``` ==> Fetching dependencies for qt@5: readline, [email protected] and gettext ``` 2. Re-installing `[email protected]` [fails](https://github.com/bitcoin/bitcoin/actions/runs/8216848118/job/22471875454#step:4:127) due to symbolic link conflicts on macOS `x86_64`: ``` ==> Pouring [email protected]_1.ventura.bottle.tar.gz Error: The `brew link` step did not complete successfully ``` 3. Homebrew's `[email protected]` is marked as externally managed (according to PEP 668), necessitating different approaches for installing Python packages. This pull request resolves all the issues mentioned above. ACKs for top commit: m3dwards: reACK acc06bc to get the CI passing again. Tree-SHA512: 82cf72bff328f1e0725342431ac14ad4bae7a758186d97db6c7a558e4b661dcbf3fabe536978e26e709c5f6f7f5c11aac46642634c6685f1291592d8d825ad87

github-actions bot added the automerge-skip `brew pr-automerge` will skip this pull request label Oct 10, 2023

branchvincent added CI-long-timeout [DEPRECATED] Use longer GitHub Actions CI timeout. CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. labels Oct 10, 2023

github-actions bot removed the CI-long-timeout [DEPRECATED] Use longer GitHub Actions CI timeout. label Oct 10, 2023

p-linnane added CI-long-timeout [DEPRECATED] Use longer GitHub Actions CI timeout. CI-linux-self-hosted Build on Linux self-hosted runner long build Set a long timeout for formula testing labels Oct 10, 2023

p-linnane force-pushed the python3.12 branch from ea621ca to 5035dd5 Compare October 10, 2023 21:54

p-linnane requested a review from Bo98 October 11, 2023 03:25

branchvincent mentioned this pull request Oct 11, 2023

condure: update to use py3.12 for test #150228

Closed

6 tasks

github-actions bot removed the CI-long-timeout [DEPRECATED] Use longer GitHub Actions CI timeout. label Oct 11, 2023

Bo98 reviewed Oct 11, 2023

View reviewed changes

Formula/p/[email protected] Outdated Show resolved Hide resolved

github-actions bot added the stale No recent activity label Nov 7, 2023

branchvincent removed the stale No recent activity label Nov 9, 2023

github-actions bot added the stale No recent activity label Dec 19, 2023

github-actions bot removed the stale No recent activity label Dec 20, 2023

github-actions bot added the stale No recent activity label Jan 11, 2024

github-actions bot removed the stale No recent activity label Jan 13, 2024

SMillerDev requested changes Jan 13, 2024

View reviewed changes

github-actions bot added the stale No recent activity label Feb 6, 2024

SMillerDev approved these changes Feb 20, 2024

View reviewed changes

cho-m reviewed Feb 20, 2024

View reviewed changes

p-linnane approved these changes Feb 20, 2024

View reviewed changes

p-linnane removed automerge-skip `brew pr-automerge` will skip this pull request in progress Stale bot should stay away CI-long-timeout [DEPRECATED] Use longer GitHub Actions CI timeout. labels Feb 20, 2024

github-actions bot added CI-long-timeout [DEPRECATED] Use longer GitHub Actions CI timeout. and removed CI-long-timeout [DEPRECATED] Use longer GitHub Actions CI timeout. labels Feb 20, 2024

branchvincent mentioned this pull request Feb 21, 2024

llvm@13: update 13.0.1_2 bottle. #163490

Merged

branchvincent added 2 commits February 21, 2024 17:00

[email protected]: update 3.11.7_2 bottle.

ac615de

[email protected]: update 3.12.2_1 bottle.

a9ac0c8

github-actions bot added the CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. label Feb 21, 2024

github-actions bot approved these changes Feb 21, 2024

View reviewed changes

BrewTestBot enabled auto-merge February 21, 2024 17:03

BrewTestBot added this pull request to the merge queue Feb 21, 2024

Merged via the queue into Homebrew:master with commit 0cefaa8 Feb 21, 2024
12 checks passed

branchvincent deleted the python3.12 branch February 21, 2024 17:14

cho-m mentioned this pull request Feb 21, 2024

libcap-ng: work around Homebrew dir structure to install Python bindings #163561

Merged

6 tasks

jwnimmer-tri mentioned this pull request Feb 21, 2024

Upgrade macOS to Python 3.12 to match Homebrew RobotLocomotion/drake#20294

Closed

7 tasks

scpeters mentioned this pull request Feb 23, 2024

Use [email protected] for formulae with python bindings osrf/homebrew-simulation#2580

Closed

9 tasks

chenrui333 added a commit to chenrui333/github-action-test that referenced this pull request Mar 8, 2024

brew-debug(macos): remove py3.12 linkage fix

cc1f883

relates to Homebrew/homebrew-core#150390 Signed-off-by: Rui Chen <[email protected]>

hebasto mentioned this pull request Mar 10, 2024

ci: Fix "macOS native" job bitcoin/bitcoin#29610

Merged

github-actions bot added the outdated PR was locked due to age label Mar 22, 2024

github-actions bot locked as resolved and limited conversation to collaborators Mar 22, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[email protected]: promote to default python3 #150390

[email protected]: promote to default python3 #150390

branchvincent commented Oct 10, 2023 •

edited

Loading

branchvincent commented Oct 11, 2023 •

edited

Loading

Bo98 commented Oct 11, 2023

github-actions bot commented Nov 7, 2023

onlined commented Nov 28, 2023

github-actions bot commented Dec 19, 2023

nickserv commented Dec 20, 2023

github-actions bot commented Jan 11, 2024

nickserv commented Jan 13, 2024

SMillerDev left a comment

cho-m commented Jan 15, 2024

github-actions bot commented Feb 6, 2024

cho-m Feb 20, 2024

p-linnane Feb 20, 2024

iMichka Feb 20, 2024

cho-m Feb 21, 2024

cho-m commented Feb 21, 2024

github-actions bot commented Feb 21, 2024

p-linnane commented Feb 21, 2024

branchvincent commented Feb 21, 2024

		tkinter is no longer included with this formula, but it is available separately:
		brew install python-tk@#{version.major_minor}

[email protected]: promote to default python3 #150390

[email protected]: promote to default python3 #150390

Conversation

branchvincent commented Oct 10, 2023 • edited Loading

branchvincent commented Oct 11, 2023 • edited Loading

Bo98 commented Oct 11, 2023

github-actions bot commented Nov 7, 2023

onlined commented Nov 28, 2023

github-actions bot commented Dec 19, 2023

nickserv commented Dec 20, 2023

github-actions bot commented Jan 11, 2024

nickserv commented Jan 13, 2024

SMillerDev left a comment

Choose a reason for hiding this comment

cho-m commented Jan 15, 2024

github-actions bot commented Feb 6, 2024

cho-m Feb 20, 2024

Choose a reason for hiding this comment

p-linnane Feb 20, 2024

Choose a reason for hiding this comment

iMichka Feb 20, 2024

Choose a reason for hiding this comment

cho-m Feb 21, 2024

Choose a reason for hiding this comment

cho-m commented Feb 21, 2024

github-actions bot commented Feb 21, 2024

p-linnane commented Feb 21, 2024

branchvincent commented Feb 21, 2024

branchvincent commented Oct 10, 2023 •

edited

Loading

branchvincent commented Oct 11, 2023 •

edited

Loading