Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*formulae: Normalize resource names from Python package name #141923

Merged
merged 13 commits into from
Sep 12, 2023

Conversation

issyl0
Copy link
Member

@issyl0 issyl0 commented Sep 10, 2023

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

@issyl0 issyl0 added the CI-no-bottles Merge without publishing bottles label Sep 10, 2023
@chenrui333
Copy link
Member

there are some formulae are deprecated/disabled, not sure if we need to touch them.

@issyl0
Copy link
Member Author

issyl0 commented Sep 10, 2023

The audit fails on them (see https://github.com/Homebrew/brew/actions/runs/6108075734/job/16576395843?pr=15942#step:6:1), so maybe we want it to come back clean? Should this new audit skip disabled formulae? Do other audits skip disabled formulae?

@github-actions github-actions bot added the autosquash Automatically squash pull request commits according to Homebrew style. label Sep 10, 2023
@chenrui333
Copy link
Member

oh, if it failed the action run, then that is good then.

@p-linnane
Copy link
Member

Can you squash the two ansible@6 commits together? Otherwise this will dispatch the PR replacement workflow to autosquash them and rerun all the jobs again 🫠

@issyl0 issyl0 force-pushed the normalize-python-resource-names branch from 61d32f0 to cd0212b Compare September 10, 2023 17:05
@github-actions github-actions bot removed the autosquash Automatically squash pull request commits according to Homebrew style. label Sep 10, 2023
@issyl0
Copy link
Member Author

issyl0 commented Sep 10, 2023

Thanks @p-linnane; done.

@issyl0
Copy link
Member Author

issyl0 commented Sep 11, 2023

The textract formula is failing to build with the following error due to deanmalmgren/textract#476.

  error in textract setup command: 'install_requires' must be a string or list of strings containing valid project/version requirement specifiers; .* suffix can only be used with `==` or `!=` operators
      extract-msg<=0.29.*

@p-linnane p-linnane added CI-syntax-only Change only affects brew syntax, not the install. Only run syntax CI. and removed CI-no-bottles Merge without publishing bottles labels Sep 12, 2023
Copy link
Member

@p-linnane p-linnane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. Thanks @issyl0!

@p-linnane p-linnane enabled auto-merge September 12, 2023 01:37
@p-linnane p-linnane added this pull request to the merge queue Sep 12, 2023
Merged via the queue into Homebrew:master with commit 6d10074 Sep 12, 2023
15 of 22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI-syntax-only Change only affects brew syntax, not the install. Only run syntax CI.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants