-
-
Notifications
You must be signed in to change notification settings - Fork 12.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
*formulae: Normalize resource names from Python package name #141923
*formulae: Normalize resource names from Python package name #141923
Conversation
there are some formulae are deprecated/disabled, not sure if we need to touch them. |
The audit fails on them (see https://github.com/Homebrew/brew/actions/runs/6108075734/job/16576395843?pr=15942#step:6:1), so maybe we want it to come back clean? Should this new audit skip disabled formulae? Do other audits skip disabled formulae? |
oh, if it failed the action run, then that is good then. |
Can you squash the two |
61d32f0
to
cd0212b
Compare
Thanks @p-linnane; done. |
The
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great. Thanks @issyl0!
HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>
, where<formula>
is the name of the formula you're submitting?brew test <formula>
, where<formula>
is the name of the formula you're submitting?brew audit --strict <formula>
(after doingHOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>
)? If this is a new formula, does it passbrew audit --new <formula>
?