Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

arm-none-eabi-binutils 2.41 arm-none-eabi-gcc 13.2.0 arm-none-eabi-gdb 13.2 (new formulae) #138370

Merged
merged 7 commits into from
Aug 5, 2023

Conversation

glingy
Copy link
Contributor

@glingy glingy commented Aug 3, 2023

Add arm-none-eabi-binutils (2.41), arm-none-eabi-gcc (13.2.0), and arm-none-eabi-gdb (13.2).

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

GNU binutils for the 32-bit ARM baremetal toolchain.
Added GCC for the 32-bit ARM baremetal toolchain.
Added GDB for the 32-bit ARM baremetal toolchain (arm-none-eabi).
@github-actions github-actions bot added new formula PR adds a new formula to Homebrew/homebrew-core automerge-skip `brew pr-automerge` will skip this pull request labels Aug 3, 2023
@fxcoudert
Copy link
Member

Thanks @glingy for your contribution to Homebrew! I'm adding checks so that the versions of binutils, gcc and gdb in those new formulas stay in sync with other targets.

@fxcoudert fxcoudert added the ready to merge PR can be merged once CI is green label Aug 4, 2023
@glingy
Copy link
Contributor Author

glingy commented Aug 4, 2023

I didn't know that version check file existed, thanks!

@github-actions
Copy link
Contributor

github-actions bot commented Aug 4, 2023

Thanks for contributing to Homebrew! 🎉 It looks like you're having trouble with a CI failure. See our contribution guide for help. You may be most interested in the section on dealing with CI failures. You can find the CI logs in the Checks tab of your pull request.

@glingy
Copy link
Contributor Author

glingy commented Aug 5, 2023

@chenrui333 Is there a way to manually re-run the failing test? It doesn't seem to have a good failure reason except something got stuck and the build froze?

@ZhongRuoyu
Copy link
Member

Is there a way to manually re-run the failing test?

I've triggered a rerun.

@ZhongRuoyu ZhongRuoyu changed the title Add 32-bit ARM Baremetal Toolchain (arm-none-eabi-*) arm-none-eabi-binutils 2.41 arm-none-eabi-gcc 13.2.0 arm-none-eabi-gdb 13.2 (new formulae) Aug 5, 2023
@ZhongRuoyu
Copy link
Member

Thanks @glingy!

@github-actions
Copy link
Contributor

github-actions bot commented Aug 5, 2023

@github-actions github-actions bot added the CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. label Aug 5, 2023
@BrewTestBot BrewTestBot added this pull request to the merge queue Aug 5, 2023
Merged via the queue into Homebrew:master with commit 9bb100e Aug 5, 2023
12 checks passed
@fauxpark
Copy link
Contributor

fauxpark commented Aug 7, 2023

Hi, what is the point of this? It does not include newlib nor have multilib enabled. It also conflicts with the osx-cross tap (see above) which has a much more functional ARM toolchain in several versions.

@fxcoudert
Copy link
Member

We would be glad to consider improvements to the formula, to make a more complete toolchain.

@github-actions github-actions bot added the outdated PR was locked due to age label Sep 7, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 7, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
automerge-skip `brew pr-automerge` will skip this pull request CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. new formula PR adds a new formula to Homebrew/homebrew-core outdated PR was locked due to age ready to merge PR can be merged once CI is green
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants