Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

helix: improve test #109424

Merged
merged 2 commits into from
Sep 2, 2022
Merged

helix: improve test #109424

merged 2 commits into from
Sep 2, 2022

Conversation

aslilac
Copy link
Contributor

@aslilac aslilac commented Sep 1, 2022

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

hx --health does a much more thorough "things are working" test than just printing out the help info, so let's do that instead!

@BrewTestBot BrewTestBot added the rust Rust use is a significant feature of the PR or issue label Sep 1, 2022
@chenrui333 chenrui333 added the CI-no-bottles Merge without publishing bottles label Sep 1, 2022
@chenrui333
Copy link
Member

why not merge this into #109423?

@aslilac
Copy link
Contributor Author

aslilac commented Sep 1, 2022

I can do it as one PR if you prefer, I just thought they were unrelated enough for two 🤷‍♀️

Formula/helix.rb Outdated Show resolved Hide resolved
Co-authored-by: Michael Davis <[email protected]>
@chenrui333
Copy link
Member

I can do it as one PR if you prefer, I just thought they were unrelated enough for two 🤷‍♀️

sure, no problem.

@chenrui333 chenrui333 merged commit e1648a0 into Homebrew:master Sep 2, 2022
@aslilac aslilac deleted the improve-helix-test branch September 2, 2022 01:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI-no-bottles Merge without publishing bottles rust Rust use is a significant feature of the PR or issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants