-
-
Notifications
You must be signed in to change notification settings - Fork 12.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bun 0.1.6 (new formula) #105263
bun 0.1.6 (new formula) #105263
Conversation
@jeelmakani it need to be built from source. |
Formula/bun.rb
Outdated
# Fails to build with latest zig release | ||
# Commit from latest fork: https://github.com/Jarred-Sumner/zig | ||
resource "zig" do | ||
url "https://github.com/ziglang/zig/archive/0ea51f7f494cd84a48fd997b60196d6c4254ccac.tar.gz" | ||
sha256 "7a6cf86adb7e7631f16a9ed2b8fcf461ed5cb387cc9b30f38bf182fa235b446f" | ||
end |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
https://docs.brew.sh/Acceptable-Formulae#stuff-that-requires-vendored-versions-of-homebrew-formulae
This will need to be contributed upstream before we can use it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note that this uses ziglang/zig
, so there is nothing to upstream. The Jarred-Sumner/zig
fork only seemingly serves as a pointer to the latest compatible zig commit
Speaking of vendoring, there are quiet a few vendored deps that we'll want to replace: https://github.com/oven-sh/bun/blob/main/.gitmodules
5866fa2
to
981e09d
Compare
Bun currently requires AVX2 on Intel: At least one of the action error occurring is caused by lacking AVX2:
(log excerpt) |
Bun v0.1.4 is out. |
This will be a blocker. Homebrew needs to build bottles that can run on older hardware. As I recall:
|
We can't use AVX2 for the time being because macOS 12 supports Mac Pro with Ivy Bridge, which doesn't support AVX2. |
Bun 0.1.5 has been released. |
They seems to be still working in progress on non-AVX2 build: oven-sh/bun#873 (comment)
|
Bun 0.1.6 has been released. |
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. |
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. |
depends_on "rust" => :build | ||
|
||
def install | ||
ENV["ZIG"] = buildpath/"bin/zig" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note that Zig builds with -march=native
by default (at least, the stable version does), so we want to make sure it's not doing that here. See, for example:
Lines 29 to 34 in 6fc08d0
# Fix illegal instruction errors when using bottles on older CPUs. | |
# https://github.com/Homebrew/homebrew-core/issues/92282 | |
cpu = case Hardware.oldest_cpu | |
when :arm_vortex_tempest then "apple_m1" # See `zig targets`. | |
else Hardware.oldest_cpu | |
end |
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. |
they have setup up the tap for now |
Do you want to try this again with version |
I think we never got a clear response as to whether we could avoid vendoring its dependencies, especially JavaScriptCore which is extremely slow to build in CI. |
Let's close this until we got more answers and a new proposal is made with the newest version. This has been open since July 6, and it's always a bad sign when a formula takes that much time to be approved. |
brew install --build-from-source <formula>
, where<formula>
is the name of the formula you're submitting?brew test <formula>
, where<formula>
is the name of the formula you're submitting?brew audit --strict <formula>
(after doingbrew install --build-from-source <formula>
)? If this is a new formula, does it passbrew audit --new <formula>
?