rethinkdb 2.4.2

[cho-m]

Created by brew bump

---

Created with brew bump-formula-pr.

[Bo98]

This is still using Python 2 on macOS:

* Error: missing PYTHON. Install it or specify the full path with PYTHON=

[cho-m]

This is still using Python 2 on macOS:

* Error: missing PYTHON. Install it or specify the full path with PYTHON=

I can extend env var to

ENV["PYTHON"] = which("python3") if !OS.mac? || MacOS.version >= :catalina

Not entirely sure our current Python policy, i.e. do we prefer system Python 3 now? I would say Python bindings should use Homebrew Python, but build-time/runtime is still vague.

[Bo98]

It is a bit vague, yeah.

Definitely Homebrew Python for any bindings or anything that does any sort of pip install/virtualenv. Really most runtime usages to be honest unless it's for some minor script or something that can dynamically pick up any Python on the path like npm.

For build-time, it probably doesn't matter. Can go with system (or it's really from the dev tools) Python there if there's no tight versioning requirements. Just be careful it's not secretly installing bindings is all I say and definitely make sure < Catalina is considered.

[Bo98]

This comment must be at least 10 years old.

[cho-m]

The test.proto used to check functionality hasn't been updated and causes configure error:

Test protobuf:                  error
* Error: Unable to compile sample protobuf file. Try running ./configure with the --fetch protoc option
[libprotobuf WARNING google/protobuf/compiler/parser.cc:649] No syntax specified for the proto file: mk/gen/protoc/test.proto. Please use 'syntax = "proto2";' or 'syntax = "proto3";' to specify a syntax version. (Defaulted to proto2 syntax.)
In file included from ./mk/gen/protoc//test.pb.cc:4:
In file included from ./mk/gen/protoc/test.pb.h:23:
In file included from /usr/local/include/google/protobuf/io/coded_stream.h:154:
In file included from /usr/local/include/google/protobuf/stubs/common.h:48:
* Aborting configure

The version they fetch is actually the same as our current version (3.19.4), but they bypass check in this case.

https://github.com/rethinkdb/rethinkdb/blob/v2.4.2/configure#L1083

[Bo98]

Fair enough, this isn't a blocker.

Though that error doesn't really say anything because it's just a warning, and they limit # of lines output: https://github.com/rethinkdb/rethinkdb/blob/9090794e52078e9ba10bf34e4f6c399f0f71c29e/configure#L416

[cho-m]

I increased errors and looks like test is failing on default c++ standard:

/usr/local/include/google/protobuf/stubs/port.h:123:2: error: "Protobuf requires at least C++11."

Could try a run with ENV.cxx11.

[Bo98]

Worth a shot I'd say.

[BrewTestBot]

🤖 A scheduled task has triggered a merge.