Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Formula for fish-app 3.0.2 #59490

Merged
merged 1 commit into from
Feb 26, 2019
Merged

Fix Formula for fish-app 3.0.2 #59490

merged 1 commit into from
Feb 26, 2019

Conversation

sanssecours
Copy link
Contributor

This commit fixes fish-shell/fish-shell#5703.

The command

brew cask style --fix fish-app

failed with the following error message on my computer:

Traceback (most recent call last):
	2: from /Users/rene/.rbenv/versions/2.6.1/bin/rubocop:23:in `<main>'
	1: from /Users/rene/.rbenv/versions/2.6.1/lib/ruby/2.6.0/rubygems.rb:302:in `activate_bin_path'
/Users/rene/.rbenv/versions/2.6.1/lib/ruby/2.6.0/rubygems.rb:283:in `find_spec_for_exe': can't find gem rubocop (>= 0.a) with executable rubocop (Gem::GemNotFoundException)

. Unfortunately installing rubocop via

gem install rubocop

did not fix the problem.

After making all changes to the cask:

  • brew cask audit --download fish-app is error-free.
  • brew cask style --fix fish-app reports no offenses.
  • The commit message includes the cask’s name and version.
  • The submission is for a stable version or documented exception.

@reitermarkus
Copy link
Member

brew cask style should not be using Ruby from rbenv, not sure what's up with that.

@sanssecours sanssecours deleted the 🐠 branch February 26, 2019 19:11
@sanssecours
Copy link
Contributor Author

brew cask style should not be using Ruby from rbenv, not sure what's up with that.

I would consider that normal behavior, since I changed the Ruby version via HOMEBREW_RUBY_PATH 😊. Unfortunately brew bump-formula-pr --strict does not work, if I use the vendor version of Ruby (see also: Homebrew/brew#5561).

@lock lock bot added the outdated label Mar 28, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Mar 28, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

homebrew package is broken
3 participants