Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Packer v0.6.1 #5747

Merged
merged 1 commit into from
Aug 12, 2014
Merged

Add Packer v0.6.1 #5747

merged 1 commit into from
Aug 12, 2014

Conversation

vitorgalvao
Copy link
Member

Closes #5742.

@vitorgalvao vitorgalvao mentioned this pull request Aug 12, 2014
vitorgalvao added a commit that referenced this pull request Aug 12, 2014
@vitorgalvao vitorgalvao merged commit 8fb456a into Homebrew:master Aug 12, 2014
@vitorgalvao vitorgalvao deleted the fix-5742 branch August 12, 2014 11:38
@radeksimko
Copy link
Contributor

@vitorgalvao
I guess it's a bit too late for this, but see #5364

Any particular reason why to include this -> more importantly without linking all the packer binaries?

@vitorgalvao
Copy link
Member Author

Apologies, I’ve missed that issue (I’ve only checked if the cask was already present). I do think it should be included, as that was my impression from #4228. Limiting the rule to “include binaries only if they come in a package format unsupported by homebrew(/binary)” is confusing, and makes no sense to me. Why should we be filtering submissions based on how they’re compressed (especially since that’s something that can so easily change)? Another reason we decided for inclusion was that we’re more active than homebrew/binary and many contributors already naturally gravitate towards us for binaries. We have the infrastructure, and our syntax is more familiar to those contributors, so why go against that expectation, and with a confusing (and nonsensical, I believe) “sometimes it’s ok, sometimes it’s not” rule, on top of that?

I’ll make that point on the relevant discussion, to see if we can reach a consensus. However, I disagree your comment was late (thanks to github’s new “revert”, it’s even easier to fix), and I agree that other submission is superior. I’m going then to revert this one, and if we agree in the matter, we can consider the previous contribution.

Thank you for bringing this to attention.

@Homebrew Homebrew locked and limited conversation to collaborators May 8, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants