Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add neovim v0.3.1 #53661

Closed
wants to merge 1 commit into from
Closed

Add neovim v0.3.1 #53661

wants to merge 1 commit into from

Conversation

ericbn
Copy link
Contributor

@ericbn ericbn commented Oct 16, 2018

as now it's being distributed as a macOS binary, and we don't need to exclusively depend on the many-required-dependencies homebrew-core formula anymore.

After making all changes to the cask:

  • brew cask audit --download {{cask_file}} is error-free.
  • brew cask style --fix {{cask_file}} reports no offenses.
  • The commit message includes the cask’s name and version.
  • The submission is for a stable version or documented exception.

Additionally, if adding a new cask:

as now it's being distributed as a macOS binary, and we don't need to
exclusively depend on the many-required-dependencies homebrew-code
formula anymore.
@ericbn
Copy link
Contributor Author

ericbn commented Oct 16, 2018

The build failed with:

audit for neovim: warning
 - possible duplicate, cask token conflicts with Homebrew core formula: https://github.com/Homebrew/homebrew-core/blob/master/Formula/neovim.rb
style
2.84s==> brew cask style neovim ✘
style check failed

I'm assuming it's not an issue to have a duplicate name for a duplicate app with homebrew-core, as it's the intention here to have the binary distribution of the same app.

Regarding the "style check failed", that's not what I get locally:

%  brew cask style --fix Casks/neovim.rb

1 file inspected, no offenses detected

@ShivaHuang
Copy link
Contributor

There are issues with cask style. Please reference to #52775

@vitorgalvao
Copy link
Member

CLI-only open-source tool, so we can’t accept it. This policy is documented in faq/rejected_casks:

The app is both open-source and CLI-only (i.e. it only uses the binary artifact). In that case, and in the spirit of deduplication, submit it first to Homebrew/core as a formula that builds from source. If it is rejected, you may then try again as a cask (link us to the issue so we can see the discussion and reasoning for rejection).

@ericbn ericbn deleted the neovim branch October 16, 2018 15:48
@lock lock bot locked and limited conversation to collaborators Nov 15, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants