Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Cask: gfortran 6.1 #40065

Merged
merged 5 commits into from
Oct 29, 2017
Merged

New Cask: gfortran 6.1 #40065

merged 5 commits into from
Oct 29, 2017

Conversation

jeroen
Copy link
Contributor

@jeroen jeroen commented Oct 26, 2017

After making all changes to the cask:

  • brew cask audit --download {{cask_file}} is error-free.
  • brew cask style --fix {{cask_file}} reports no offenses.
  • The commit message includes the cask’s name and version.

Additionally, if adding a new cask:

  • Named the cask according to the token reference.
  • brew cask install {{cask_file}} worked successfully.
  • brew cask uninstall {{cask_file}} worked successfully.
  • Checked there are no open pull requests for the same cask.
  • Checked the cask was not already refused in closed issues.
  • Checked the cask is submitted to the correct repo.

Provides the official GNU gfortran builds. Technically, this is a dependency of the r-app Cask, but in practice it is only needed to install R packages with fortran code. More details are given on the r-project website in particular this fragment:

Important note: R 3.4.0 El Capitan binaries are using Clang 4.0.0 and GNU Fortran 6.1 to provide OpenMP parallelization support and C++17 standard features. If you want to compile R packages from sources, please download GNU Fortran binary from the official GNU Fortran Binaries page - in particular OS X 10.11 gfortran 6.1.

The build gfortran that ships with homebrew gcc is incompatible with the gfortran runtime that ships with r-app. Thanks for considering.

@vitorgalvao
Copy link
Member

Thank you for the submission.

This seems to be a CLI-only open-source tool. Please submit it first to Homebrew/core and only if they don’t accept it, submit here (linking back to the pull request where it was refused).

This policy is documented in faq/rejected_casks:

The app is both open-source and CLI-only (i.e. it only uses the binary artifact). In that case, and in the spirit of deduplication, submit it first to Homebrew/core. If it is rejected there, you may then try again in Homebrew-Cask (link us to the issue on Homebrew so we can see their reasoning for rejection).

@jeroen
Copy link
Contributor Author

jeroen commented Oct 26, 2017

I don't understand. Should I submit the cask to core? Or try to reverse engineer a Formula?

The problem is that gfortran is part of gcc which is already in core, but we need the official binary build from the GNU website.

@vitorgalvao vitorgalvao reopened this Oct 26, 2017
@commitay
Copy link
Contributor

commitay commented Oct 26, 2017

@jeroen Is 6.1 specifically needed or should it be dependent on macOS version?

@commitay commitay added the awaiting user reply Issue needs response from a user. label Oct 26, 2017
@jeroen
Copy link
Contributor Author

jeroen commented Oct 26, 2017

We specifically like use the 6.1 version. This build targets el-capitain so it works on all currently supported versions of MacOS (10.11, 10.12, 10.13).

@commitay
Copy link
Contributor

@vitorgalvao I think this would be better suited in a personal tap because the use case won't support the usual if MacOS.version and 6.1 is not the latest release.

@commitay commitay added awaiting maintainer feedback Issue needs response from a maintainer. and removed awaiting user reply Issue needs response from a user. labels Oct 26, 2017
@jeroen
Copy link
Contributor Author

jeroen commented Oct 26, 2017

The 6.1 build is the latest version that works on all currently supported MacOS versions. The latest official binary from the GNU website is 6.3 for Sierra. We could conditionally install the 6.3 version on Sierra and up. For simplicity R uses the 6.1 build everywhere so that we have a single toolchain for all MacOS users, but either way is fine by me.

Sure I can host it in my own tap, but I do think that the official Fortran for MacOS (that does not require the entire gcc) may be more useful to other users, not just me :) Anyway your call.

@commitay
Copy link
Contributor

commitay commented Oct 26, 2017

Can you add the Sierra version, conflicts with formula: 'gcc' and add pkgutil to the uninstall please?

@miccal miccal added the awaiting user reply Issue needs response from a user. label Oct 26, 2017
@miccal
Copy link
Member

miccal commented Oct 27, 2017

screen shot 2017-10-27 at 10 49 02

To install any of them, you need to have the Apple Developer Tools installed, as well as "command line developer tools".

So does this need the full Xcode, or are the CLT enough?

@miccal
Copy link
Member

miccal commented Oct 27, 2017

screen shot 2017-10-27 at 10 50 20

According to the READEM.html, a full Xcode is required.

@jeroen
Copy link
Contributor Author

jeroen commented Oct 27, 2017

I'v been using it on a VM with only CLT and it works fine as far as I can tell.

@commitay
Copy link
Contributor

@vitorgalvao What do you think about adding this to versions as gfortran61?

@commitay commitay removed the awaiting user reply Issue needs response from a user. label Oct 27, 2017
@jeroen
Copy link
Contributor Author

jeroen commented Oct 27, 2017

I have conditioned the version on the MacOS version in the last commit. Not sure I like it but it seems to work.

@@ -0,0 +1,30 @@
cask 'gfortran' do
# coudert.name/software was verified as official when first introduced to the cask
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be located directly above url, even if it means repeating it. Each URL is verified independently.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You sure? It seems to pass the audit. Anyway will update.

@vitorgalvao
Copy link
Member

vitorgalvao commented Oct 27, 2017

@vitorgalvao What do you think about adding this to versions as gfortran61?

If there’s a reason a Sierra (and up) user would want that version, yes. Otherwise, this one should be enough. I’m doubting the usefulness (amount of people that’ll take advantage of) this cask already as it is; it’s harder to justify two casks across two repos.

@commitay commitay removed the awaiting maintainer feedback Issue needs response from a maintainer. label Oct 27, 2017
@commitay commitay merged commit 07c2950 into Homebrew:master Oct 29, 2017
@Homebrew Homebrew locked and limited conversation to collaborators May 9, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants