-
-
Notifications
You must be signed in to change notification settings - Fork 10.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New Cask: gfortran 6.1 #40065
New Cask: gfortran 6.1 #40065
Conversation
Thank you for the submission. This seems to be a CLI-only open-source tool. Please submit it first to Homebrew/core and only if they don’t accept it, submit here (linking back to the pull request where it was refused). This policy is documented in faq/rejected_casks:
|
I don't understand. Should I submit the cask to core? Or try to reverse engineer a Formula? The problem is that |
@jeroen Is |
We specifically like use the 6.1 version. This build targets el-capitain so it works on all currently supported versions of MacOS (10.11, 10.12, 10.13). |
@vitorgalvao I think this would be better suited in a personal tap because the use case won't support the usual |
The 6.1 build is the latest version that works on all currently supported MacOS versions. The latest official binary from the GNU website is 6.3 for Sierra. We could conditionally install the 6.3 version on Sierra and up. For simplicity R uses the 6.1 build everywhere so that we have a single toolchain for all MacOS users, but either way is fine by me. Sure I can host it in my own tap, but I do think that the official Fortran for MacOS (that does not require the entire gcc) may be more useful to other users, not just me :) Anyway your call. |
Can you add the |
I'v been using it on a VM with only CLT and it works fine as far as I can tell. |
@vitorgalvao What do you think about adding this to |
I have conditioned the version on the MacOS version in the last commit. Not sure I like it but it seems to work. |
Casks/gfortran.rb
Outdated
@@ -0,0 +1,30 @@ | |||
cask 'gfortran' do | |||
# coudert.name/software was verified as official when first introduced to the cask |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be located directly above url
, even if it means repeating it. Each URL is verified independently.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You sure? It seems to pass the audit. Anyway will update.
If there’s a reason a Sierra (and up) user would want that version, yes. Otherwise, this one should be enough. I’m doubting the usefulness (amount of people that’ll take advantage of) this cask already as it is; it’s harder to justify two casks across two repos. |
After making all changes to the cask:
brew cask audit --download {{cask_file}}
is error-free.brew cask style --fix {{cask_file}}
reports no offenses.Additionally, if adding a new cask:
brew cask install {{cask_file}}
worked successfully.brew cask uninstall {{cask_file}}
worked successfully.Provides the official GNU gfortran builds. Technically, this is a dependency of the
r-app
Cask, but in practice it is only needed to install R packages with fortran code. More details are given on the r-project website in particular this fragment:The build gfortran that ships with homebrew
gcc
is incompatible with the gfortran runtime that ships withr-app
. Thanks for considering.