Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated caveat in MacTeX to zsh-only #3685

Merged
merged 1 commit into from
Mar 31, 2014
Merged

Updated caveat in MacTeX to zsh-only #3685

merged 1 commit into from
Mar 31, 2014

Conversation

szhu
Copy link
Contributor

@szhu szhu commented Mar 26, 2014

MacTeX already adds itself to $PATH for non-zsh shells, so no need to have the user manually do it. Changed the caveat from path_environment_variable to zsh_path_helper, as added in #3699.

Addresses part of #3597.

@rolandwalker rolandwalker mentioned this pull request Mar 27, 2014
Merged
@rolandwalker
Copy link
Contributor

Per @goxberry's comment in #3597, this seems like the wrong way to go after all. I'm proposing #3699 instead.

The original idea in #3597 was that we add the ability to manipulate the contents of /etc/paths.d. That still seems worth doing.

@szhu szhu changed the title Removed caveat from MacTeX Updated caveat in MacTeX to zsh-only Mar 31, 2014
@szhu
Copy link
Contributor Author

szhu commented Mar 31, 2014

I updated this PR, integrating zsh_path_helper from #3699.

@rolandwalker
Copy link
Contributor

Thanks!

rolandwalker added a commit that referenced this pull request Mar 31, 2014
@rolandwalker
Merge pull request #3685 from interestinglythere/3597-fix-mactex
342efd9 
Updated caveat in MacTeX to zsh-only
@rolandwalker rolandwalker merged commit 342efd9 into Homebrew:master Mar 31, 2014
@szhu szhu mentioned this pull request Apr 3, 2014
Closed
@szhu szhu deleted the 3597-fix-mactex branch April 7, 2014 01:15
@Homebrew Homebrew locked and limited conversation to collaborators May 8, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@szhu @rolandwalker