Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated displaycal (3.1.4.0) #23020

Closed
wants to merge 1 commit into from
Closed

updated displaycal (3.1.4.0) #23020

wants to merge 1 commit into from

Conversation

shonjir
Copy link
Contributor

@shonjir shonjir commented Jul 23, 2016

Changes to a cask

Editing an existing cask

  • Commit message includes cask’s name (and new version, if applicable).
  • brew cask audit --download {{cask_file}} is error-free.
  • brew cask style --fix {{cask_file}} left no offenses.

@shonjir
Copy link
Contributor Author

shonjir commented Jul 24, 2016

Travis appears to be hanging on 'brew cask audit' step. It appears this happens when executing manually also, but worked when executed from cask-repair.

@adidalal
Copy link
Contributor

I can restart Travis and see if it helps

@reitermarkus
Copy link
Member

@adidalal, already restarted it two times. Also tried locally, doesn't work either.

@shonjir
Copy link
Contributor Author

shonjir commented Jul 24, 2016

I suspect this isn't going to work. It looks like brew cask audit is hanging at the appcast check. A spot check of other casks shows that it works for most, but not with sourceforge appcasts that contain uri request parameters (?path=...)

A quick search gives me the following casks that seem to exhibit this behavior:

animated-gif-quicklook.rb
displaycal.rb
freesmug-chromium.rb
grandperspective.rb
grisbi.rb
klatexformula.rb
qbittorrent.rb
seashore.rb
squirrelsql.rb
supertuxkart.rb

It's odd because cask audit just sets up a curl request that works fine when executed manually.

@shonjir
Copy link
Contributor Author

shonjir commented Jul 25, 2016

Passes travis with fix from #23050

@reitermarkus
Copy link
Member

Thank you for the contribution. It was merged directly as 2a342b7 to keep commit history cleaner. Your contribution is still credited to you.

reitermarkus pushed a commit that referenced this pull request Jul 25, 2016
@shonjir shonjir deleted the cask-repair_update-displaycal branch October 3, 2016 06:09
@Homebrew Homebrew locked and limited conversation to collaborators May 9, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants