Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

font-harmonyos-sans* 1.0.0 (new cask) #197897

Closed
wants to merge 2 commits into from

Conversation

sgalcheung
Copy link

Important: Do not tick a checkbox if you haven’t performed its action. Honesty is indispensable for a smooth review process.

In the following questions <cask> is the token of the cask you're submitting.

After making any changes to a cask, existing or new, verify:

Additionally, if adding a new cask:

  • Named the cask according to the token reference.
  • Checked the cask was not already refused (add your cask's name to the end of the search field).
  • brew audit --cask --new <cask> worked successfully.
  • HOMEBREW_NO_INSTALL_FROM_API=1 brew install --cask <cask> worked successfully.
  • brew uninstall --cask <cask> worked successfully.

Here are some operation logs

❯ brew audit --new --cask font-harmonyos-sans
==> Downloading https://communityfile-drcn.op.dbankcloud.cn/FileServer/getFile/cmtyPub/011/111/111/0000000000011111111.20240403121718.4852073145968538323
Already downloaded: /Users/sgalcheung/Library/Caches/Homebrew/downloads/46d8192e68a866a9c7474737740aaf57b42b02b261c9a1f50edf2366e1540958--HarmonyOS
audit for font-harmonyos-sans: failed

  • Use sha256 :no_check when URL is unversioned.
    font-harmonyos-sans
  • Use sha256 :no_check when URL is unversioned.
    Error: 1 problem in 1 cask detected.

❯ brew install --cask font-harmonyos-sans
==> Downloading https://communityfile-drcn.op.dbankcloud.cn/FileServer/getFile/cmtyPub/011/111/111/0000000000011111111.20240403121718.4852073145968538323
Already downloaded: /Users/sgalcheung/Library/Caches/Homebrew/downloads/46d8192e68a866a9c7474737740aaf57b42b02b261c9a1f50edf2366e1540958--HarmonyOS
==> Installing Cask font-harmonyos-sans
==> Moving Font 'HarmonyOS_Sans_Regular.ttf' to '/Users/sgalcheung/Library/Fonts/HarmonyOS_Sans_Regular.ttf'
==> Moving Font 'HarmonyOS_Sans_Thin.ttf' to '/Users/sgalcheung/Library/Fonts/HarmonyOS_Sans_Thin.ttf'
==> Moving Font 'HarmonyOS_Sans_Light.ttf' to '/Users/sgalcheung/Library/Fonts/HarmonyOS_Sans_Light.ttf'
==> Moving Font 'HarmonyOS_Sans_Medium.ttf' to '/Users/sgalcheung/Library/Fonts/HarmonyOS_Sans_Medium.ttf'
==> Moving Font 'HarmonyOS_Sans_Bold.ttf' to '/Users/sgalcheung/Library/Fonts/HarmonyOS_Sans_Bold.ttf'
==> Moving Font 'HarmonyOS_Sans_Black.ttf' to '/Users/sgalcheung/Library/Fonts/HarmonyOS_Sans_Black.ttf'
🍺 font-harmonyos-sans was successfully installed!

Reference: Homebrew/brew#19068

@BrewTestBot BrewTestBot added automerge-skip new cask missing zap Cask is missing a zap stanza, please add one. labels Jan 11, 2025
@BrewTestBot BrewTestBot removed the missing zap Cask is missing a zap stanza, please add one. label Jan 11, 2025
@daeho-ro daeho-ro changed the title Add HarmonyOS Sans font. font-harmonyos-sans* 1.0.0 (new cask) Jan 11, 2025
version "1.0.0"
sha256 "806e68b8cad06848d60da7211519c7b70a81588cdc19cec0d7238057a0726d3e"

url "https://communityfile-drcn.op.dbankcloud.cn/FileServer/getFile/cmtyPub/011/111/111/0000000000011111111.20240403121718.48520731459685383233360410352014:50001231000000:2800:7FB2B50B19EC97800A168DF9C9CF265C179E196BA93EAFD5E7F4E23F50E67C43.zip?needInitFileName=true",
Copy link
Member

@bevanjkay bevanjkay Jan 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution to homebrew-cask.

I'm concerned that the url for each of these casks will not be stable.
If the url changes when the version changes, or updates are made, then we need a way to capture the variability. Often this is done using a livecheck stanza.

Copy link
Author

@sgalcheung sgalcheung Jan 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This current version is stable, but if we consider handling future update versions, it seems the homepage will change from V1 to V2 or Vx, the URL is not related to the homepage, it is a download URL, so It is hard to handle it automatically.

Whether we accept an unofficial resource or not, I found the most start repo(huawei-fonts/HarmonyOS-Sans) on GitHub.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunately, we can't accept an unofficial source.
If there download url will have a level of instability between versions, then this cask wouldn't be suitable for inclusion in homebrew-cask.

Perhaps consider hosting it in your own tap where you can handle updates in a more manual way, and still enjoy the benefits of installing with Homebrew.

@p-linnane p-linnane requested a review from bevanjkay January 14, 2025 02:00
@bevanjkay bevanjkay closed this Jan 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants