Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jellyfin-media-player 1.10.0 #173856

Merged
merged 2 commits into from
May 15, 2024

Conversation

jakobzudrell
Copy link
Contributor

@jakobzudrell jakobzudrell commented May 15, 2024

Important: Do not tick a checkbox if you haven’t performed its action. Honesty is indispensable for a smooth review process.

In the following questions jellyfin-media-player is the token of the cask you're submitting.

After making any changes to a cask, existing or new, verify:


NOTE: I was only able to test AppleSilicon, so if someone could confirm this for Intel that'd be great, so the pull request can be merged :)

@bevanjkay bevanjkay changed the title Jellyfin media player 1.10.0 jellyfin-media-player 1.10.0 May 15, 2024
@bevanjkay bevanjkay enabled auto-merge May 15, 2024 13:38
Copy link
Member

@bevanjkay bevanjkay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @jakobzudrell

@bevanjkay bevanjkay merged commit 8e3d63d into Homebrew:master May 15, 2024
11 checks passed
@jakobzudrell jakobzudrell deleted the jellyfin-media-player-1.10.0 branch May 15, 2024 13:54
@privacymatters1
Copy link

I had problems installing the update on a 2019 Intel MacBook Pro 16 with MacOS 14.4.1

==> Moving App 'Jellyfin Media Player.app' to '/Applications/Jellyfin Media Player.app'
:0: error: invalid Darwin version number: macosx14
:0: error: invalid version number in '--target=x86_64-apple-macosx14'
==> Purging files for version 1.10.0 of Cask jellyfin-media-player
==> Purging files for version 1.10.0 of Cask jellyfin-media-player
Warning: Reverting upgrade for Cask jellyfin-media-player
==> Purging files for version 1.9.1 of Cask jellyfin-media-player
Error: jellyfin-media-player: It seems there is already an App at '/Applications/Jellyfin Media Player.app'.

after that error it was not possible to open Jellyfin-Media-Player

@jakobzudrell
Copy link
Contributor Author

jakobzudrell commented May 15, 2024

Hey @privacymatters1 ,

my experience with homebrew is limited but I'll do my best to help.. Can you post the exact command which resulted in this error?
Do you think this might be related to jellyfin/jellyfin-media-player#623?

@privacymatters1
Copy link

sure, my command was just "brew upgrade".

I'm not a developer, but I tried a little and got to the conclusion that homebrew is not the problem.

I deinstalled Jellyfin-Media-Player und reinstalled it with homebrew again and the installation in homebrew was no problem, but opening got me to the same error as many others are experiencing. like the screenshot in jellyfin/jellyfin-media-player#623 (comment) and also installing the app manual from jellyfin-github got me the same error, so I think the problem has nothing to do with hombrew.

Nevertheless, thank you for answering.

@jakobzudrell
Copy link
Contributor Author

Yeah, I think that is an already known issue with their current build. There is already a PR open that should fix this, all we can do now is wait for that to happen :)

lwolfsonkin added a commit to lwolfsonkin/homebrew-cask that referenced this pull request Oct 12, 2024
* Up until a couple months ago, Jellyfin Media Player did not support Apple Silicon explicitly
* jellyfin-media-player 1.10.0 and later versions have added separate Apple Silicon builds, but the Intel build requires 12+ (Monterey or later) while the Apple Silicon build requires 14+ (Sonoma or later) (jellyfin/jellyfin-media-player#699)
* Homebrew#173856 added jellyfin-media-player 1.10.0 support to `brew`, but didn't encode the above system arch restrictions
* As a result, anyone on Monterey or Ventura who did a `brew upgrade` would get immediate crashes on startup as in jellyfin/jellyfin-media-player#681 and jellyfin/jellyfin-media-player#668
* Now, we use the Intel build via Rosetta on Apple Silicon devices for pre-Sonoma releases, which fixes the above crashes, making this program usable
* We now also encode the minimum supported release as macOS Monterey
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants