Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Arturia software #17321

Closed
wants to merge 1 commit into from
Closed

Add Arturia software #17321

wants to merge 1 commit into from

Conversation

joshka
Copy link
Contributor

@joshka joshka commented Jan 19, 2016

This includes casks for:

  • Analog Lab
  • Midi Control Center
  • Mini V
  • Software Center

I wasn't entirely sure whether this required one commit per product, or if you're happy with a single commit here. There are many more Arturia products available here, but as I don't have licenses for any of these, I can't check that they work etc.

Also note. Analog Lab and Mini V both have demo versions available with the following limitations

Saving/Loading and import/export are disabled. The demo is limited to 20 minutes.

I wasn't sure whether this qualified the product as one where license :freemium applies or if what I put (license: commercial) was better here.

Analog Lab
Midi Control Center
Mini V
Software Center
@jawshooah
Copy link
Contributor

I wasn't entirely sure whether this required one commit per product, or if you're happy with a single commit here.

We do prefer one commit per cask.

I wasn't sure whether this qualified the product as one where license :freemium applies or if what I put (license: commercial) was better here.

The demo expires, so it's not really freemium. :commercial is fine.

@@ -0,0 +1,11 @@
cask 'arturia-analog-lab' do
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should just be analog-lab in keeping with the token reference.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jawshooah I wasn't sure, however given that there is a lot of arturia software, I think it makes sense to prefix this. Is this a valid reason? See http://www.arturia.com/products

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this a valid reason?

Nope. The token reference is intentionally strict to prevent duplicates, which were a huge problem before it was implemented. These casks will still show up in brew cask search arturia though since the vendor is in the name stanza.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll fix tomorrow.

@joshka joshka closed this Jan 19, 2016
@joshka joshka deleted the feature/arturia branch January 19, 2016 18:18
@joshka joshka mentioned this pull request Jan 19, 2016
@Homebrew Homebrew locked and limited conversation to collaborators May 8, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants