Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cask-drivers: migrate casks to homebrew/cask #145059

Merged
merged 11 commits into from
Apr 14, 2023

Conversation

razvanazamfirei
Copy link
Member

@razvanazamfirei razvanazamfirei commented Apr 13, 2023

Migrating cask-drivers. Merge at the same time as Homebrew/homebrew-cask-drivers#3418

@samford
Copy link
Member

samford commented Apr 13, 2023

I was about to open a PR for the casks that I use in homebrew/cask-drivers but you already have one of them here (qmk-toolbox) 👍

The other ones I was going to address are elgato-camera-hub (for Mike), elgato-control-center, and fujitsu-scansnap-home but it may be easier to just add them to this instead. Would you mind migrating these as well or, alternatively, if I add commits to the related PR branches?

@razvanazamfirei
Copy link
Member Author

@samford, sure I can add them!

@razvanazamfirei
Copy link
Member Author

Having the same issue as yesterday with verifying signatures. pkgutil verifies the signature and notarization, while codesign cannot find a signature.

❯ pkgutil --check-signature /Volumes/Garmin\ Express/Install\ Garmin\ Express.pkg
Package "Install Garmin Express.pkg":
   Status: signed by a developer certificate issued by Apple for distribution
   Notarization: trusted by the Apple notary service
   Signed with a trusted timestamp on: 2023-02-01 19:40:56 +0000
   Certificate Chain:
    1. Developer ID Installer: Garmin International (72ES32VZUA)
       Expires: 2024-02-28 13:29:04 +0000
       SHA256 Fingerprint:
           98 BD 84 71 CF 29 46 A5 7E 82 00 26 42 86 11 A5 39 4D 32 2B E0 C2
           73 A7 99 99 74 04 E8 17 FD 2C
       ------------------------------------------------------------------------
    2. Developer ID Certification Authority
       Expires: 2027-02-01 22:12:15 +0000
       SHA256 Fingerprint:
           7A FC 9D 01 A6 2F 03 A2 DE 96 37 93 6D 4A FE 68 09 0D 2D E1 8D 03
           F2 9C 88 CF B0 B1 BA 63 58 7F
       ------------------------------------------------------------------------
    3. Apple Root CA
       Expires: 2035-02-09 21:40:36 +0000
       SHA256 Fingerprint:
           B0 B1 73 0E CB C7 FF 45 05 14 2C 49 F1 29 5E 6E DA 6B CA ED 7E 2C
           68 C5 BE 91 B5 A1 10 01 F0 24
❯ pkgutil --check-signature /Volumes/Synology\ Drive\ Client/Install\ Synology\ Drive\ Client.pkg
Package "Install Synology Drive Client.pkg":
   Status: signed by a developer certificate issued by Apple for distribution
   Notarization: trusted by the Apple notary service
   Signed with a trusted timestamp on: 2023-02-02 06:10:34 +0000
   Certificate Chain:
    1. Developer ID Installer: Synology Inc. (X85BAK35Y4)
       Expires: 2027-02-01 22:12:15 +0000
       SHA256 Fingerprint:
           66 97 77 51 52 A8 20 F3 D0 1E 77 3B 06 95 C7 AF 1C 68 3E 28 0B 06
           AF 93 CD 5E 82 46 F0 E9 33 6B
       ------------------------------------------------------------------------
    2. Developer ID Certification Authority
       Expires: 2027-02-01 22:12:15 +0000
       SHA256 Fingerprint:
           7A FC 9D 01 A6 2F 03 A2 DE 96 37 93 6D 4A FE 68 09 0D 2D E1 8D 03
           F2 9C 88 CF B0 B1 BA 63 58 7F
       ------------------------------------------------------------------------
    3. Apple Root CA
       Expires: 2035-02-09 21:40:36 +0000
       SHA256 Fingerprint:
           B0 B1 73 0E CB C7 FF 45 05 14 2C 49 F1 29 5E 6E DA 6B CA ED 7E 2C
           68 C5 BE 91 B5 A1 10 01 F0 24

@razvanazamfirei
Copy link
Member Author

fujitsu-scansnap-home does not have version 2.10.0 available for download. The other two casks have signing-related errors as per above. Switching CI to syntax only.

@razvanazamfirei razvanazamfirei added the ci-syntax-only Only run syntax checks on CI. Use only for bulk changes. label Apr 13, 2023
@razvanazamfirei razvanazamfirei marked this pull request as ready for review April 13, 2023 19:36
@p-linnane p-linnane merged commit 0c6f4e5 into Homebrew:master Apr 14, 2023
@razvanazamfirei razvanazamfirei deleted the migrate-cask branch April 14, 2023 03:05
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 15, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
automerge-skip ci-syntax-only Only run syntax checks on CI. Use only for bulk changes. outdated
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants