Skip to content
This repository has been archived by the owner on May 16, 2024. It is now read-only.

Update FiraCode Nerd Font #1940

Closed
wants to merge 1 commit into from
Closed

Update FiraCode Nerd Font #1940

wants to merge 1 commit into from

Conversation

julienma
Copy link
Contributor

@julienma julienma commented Jan 27, 2020

After making all changes to the cask:

  • brew cask audit --download {{cask_file}} is error-free.
  • brew cask style --fix {{cask_file}} reports no offenses.
  • The commit message includes the cask’s name and version.
  • The submission is for a stable version or documented exception.

Additionally, if adding a new cask:

@julienma
Copy link
Contributor Author

This update downloads the font files directly, instead of the repo release which is way outdated.

This fixes 2 issues:

@vitorgalvao
Copy link
Member

No need to use svn, you can download the master zip.

But a better solution is to ask upstream to cut a new release. We prefer that to workarounds.

@vitorgalvao vitorgalvao added the awaiting user reply Issue needs response from a user. label Jan 28, 2020
@vitorgalvao vitorgalvao mentioned this pull request Jan 28, 2020
10 tasks
@julienma
Copy link
Contributor Author

julienma commented Jan 28, 2020

Thanks for the reply.

I’ll ask for a new release, but I’m not confident: current milestone is past due 2 years, and considering there are dozens more fonts in this repo, it’d involve a lot more work than cutting a new release just for a single font.

Re: downloading the master zip, would that be better than selectively downloading files via svn? There are dozens of fonts in that repo, it seems a waste of bandwidth to download a big zip just to keep a handful of files.

@parkerbxyz
Copy link

Re: cutting a new release, the commit message here seems to indicate a new release may be imminent: ryanoasis/nerd-fonts@fa69496.

@ryanoasis
Copy link
Contributor

Release has been cut, not sure if this will change what you want to do here, just an FYI

@vitorgalvao
Copy link
Member

@ryanoasis Thank you.

@julienma It’s fine if you prefer to close this PR and open a new one. Do whatever’s most convenient.

@julienma
Copy link
Contributor Author

julienma commented Feb 3, 2020

Thank you @ryanoasis :)

@vitorgalvao I've updated the cask using cask-repair, PR is here: #1944. Closing this one. Thanks!

@julienma julienma closed this Feb 3, 2020
@lock lock bot added the outdated label Mar 10, 2020
@lock lock bot locked as resolved and limited conversation to collaborators Mar 10, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
awaiting user reply Issue needs response from a user.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants