audit: remove [email protected] from unstable spec whitelist
#5060
Conversation
|
@MikeMcQuaid Thoughts on adding an audit to disallow unstable specs for crypto/security formulae? e.g. Only Edit: |
|
@commitay Makes sense to me. Honestly I think removing
I think |
Yeah, I've been tempted to do this for a while now. Stuff like
I kind of like this idea as it would avoid long CI builds and we might actually see an increase in usage over the current Not sure about duplicating formulae and trying to keep them in sync against a moving target, unlike the other What would a devel |
Yeh, I totally forgot that we rebuild this every time 😭. It's definitely not worth that CI time.
If people find them useful (and we don't use them as dependencies): that seems like a win to me.
|
A while ago I poked around
Maybe kill off devel specs in formulae and add a core only audit?
👍 A one off formula would probably be easier than trying to maintain a permanent one. Might need to tag/audit it somehow as a "devel" formulae to make sure it isn't forgotten.
This might help for us internally but I think it might make it difficult for people who want to switch to the new version in taps and for local development. |
Yeh. My concern would also be that something will sneak in as a stable change which breaks only the stable build (and vice-versa).
I'd be in favour of this starting with those with (very) low or nonexistent install counts.
I think in an ideal, from-scratch world our versioned formulae would look a bit like Debian versions:
Ideally these would all just be I don't say this because I think it will happen soon (or maybe ever) but just in case it influences/helps anyone's plans. |
|
Currently we have 42 formulae with a devel spec + 2 open PRs, I think it would be easier to just remove them across the board and audit it as
|
Fine with me 👍 |
|
It looks like these have now been removed. I'm still a heavy user of wine --devel. It surprised me greatly when this suddenly stopped working. Is there some possibility of printing some message to the user when they try to install these formulae for a short time, describing what the replacement is ([email protected] etc. if I understand correctly ?) |
|
@woparry The best bet is probably to for these to be maintained in a tap outside of Homebrew. |
brew stylewith your changes locally?brew testswith your changes locally?Homebrew/homebrew-core#31989
Now that TLS1.3 has landed in a stable release we probably don't need to allow for an unstable spec.