-
-
Notifications
You must be signed in to change notification settings - Fork 9.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Requirement tweaks #487
Requirement tweaks #487
Conversation
@@ -31,7 +31,7 @@ def option_names | |||
|
|||
# The message to show when the requirement is not met. | |||
def message | |||
s = "" | |||
s = "#{self.class} unsatisfied!\n" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's probably a non-issue (or an irrelevant corner case), as most in-formula requirements tend to provide their own message
method, but if that wasn't the case, this would result in pretty ugly output like:
$ brew install slimerjs
slimerjs: Formulary::FormulaNamespace4237eb49a894bb8c7e324716724ef7cb::FirefoxRequirement unsatisfied!
You can install with Homebrew Cask:
brew cask install firefox
Error: An unsatisfied requirement failed this build.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 will strip everything up to and including the ::
Two minor remarks, but otherwise 👍. |
Agree with @UniqMartin's points. I think it's safe to completely remove |
Can't yet as the formula relies on it and we'll need to merge this before the formula change (and can remove afters) |
Make it more obvious which class was unsatisfied to produce this error message.
Previously this was only using the last line.
Nicer to split this onto two lines.
We’re just supporting the Cask now.
We’re just supporting the Cask now.
Bleh. Yeah, forgot this. 👍. |
brew tests
with your changes locally?More details in commit messages but: fix up tuntap and osxfuse requirements so Homebrew/homebrew-core#2075 and Homebrew/homebrew-core#2076 can be merged and tweak the requirements messaging based on the local testing of these.
CC @DomT4 @AnastasiaSulyagina