Support setting GIT_COMMITTER_NAME and GIT_COMMITTER_EMAIL
#18749
+29
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MikeMcQuaid
approved these changes
Nov 11, 2024
Our autobump workflow sets the author and committer to the user who triggered the workflow, defaulting to @BrewTestBot for scheduled runs. This can be confusing for maintainers when GitHub shows up as "Unverified" because the commit is signed with @BrewTestBot's key.[^1] Let's fix that by configuring our autobump workflow to always commit as @BrewTestBot, so that the committer matches the GPG signature. To do that, we need to add support for setting `GIT_COMMITTER_NAME` and `GIT_COMMITTER_EMAIL`. [^1]: See, for example, Homebrew/homebrew-core#197234.
carlocab
force-pushed
the
git-committer-info
branch
from
0ef261f
to
1fbe436
Compare
carlocab
added a commit
to Homebrew/homebrew-core
that referenced
this pull request
Nov 11, 2024
We can do this by setting `HOMEBREW_GIT_COMMITTER_NAME` and `HOMEBREW_GIT_COMMITTER_EMAIL`. Needs Homebrew/brew#18749, but this doesn't do anything until then, so it doesn't hurt to merge this early. This makes sure that autobump commits don't show up as "Unverified" in the GitHub UI.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
brew stylewith your changes locally?brew typecheckwith your changes locally?brew testswith your changes locally?Our autobump workflow sets the author and committer to the user who
triggered the workflow, defaulting to @BrewTestBot for scheduled runs.
This can be confusing for maintainers when GitHub shows up as
"Unverified" because the commit is signed with @BrewTestBot's key.1
Let's fix that by configuring our autobump workflow to always commit as
@BrewTestBot, so that the committer matches the GPG signature. To do
that, we need to add support for setting
GIT_COMMITTER_NAMEandGIT_COMMITTER_EMAIL.Footnotes
See, for example, fzf 0.56.1 homebrew-core#197234. ↩