CueControl: Fix previewing regression from PR mixxxdj#2194

Holzhaus · Nov 5, 2020 · b33f458 · b33f458
1 parent 529048b
commit b33f458
Showing 1 changed file with 5 additions and 5 deletions.
diff --git a/src/engine/controls/cuecontrol.cpp b/src/engine/controls/cuecontrol.cpp
@@ -1076,13 +1076,13 @@ void CueControl::hotcueActivatePreview(HotcueControl* pControl, double value) {
         // hotcue. If this hotcue is previewing:
         mixxx::CueType cueType = pControl->getPreviewingType();
         if (cueType != mixxx::CueType::Invalid) {
-            // Mark this hotcue as not previewing.
-            double position = pControl->getPreviewingPosition();
-            pControl->setPreviewingType(mixxx::CueType::Invalid);
-            pControl->setPreviewingPosition(Cue::kNoPosition);
-
             // If this is the last hotcue to leave preview.
             if (--m_iCurrentlyPreviewingHotcues == 0 && !m_bPreviewing) {
+                // Mark this hotcue as not previewing.
+                double position = pControl->getPreviewingPosition();
+                pControl->setPreviewingType(mixxx::CueType::Invalid);
+                pControl->setPreviewingPosition(Cue::kNoPosition);
+
                 m_pPlay->set(0.0);
                 // Need to unlock before emitting any signals to prevent deadlock.
                 lock.unlock();