Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewrite Dockerfile #105

Merged
merged 3 commits into from
Dec 21, 2023
Merged

Rewrite Dockerfile #105

merged 3 commits into from
Dec 21, 2023

Conversation

jim60105
Copy link
Contributor

  • Rewrite Dockerfile.
  • Add the cookies.txt file exists check in monitor.sh
  • Update docker build GitHub CI and add arm64 build.

I have revised the Dockerfile that I created two years ago. My skills improved, enabling me to create better images. Notably, I have enhanced its security measures.

Furthermore, I have made adjustments to monitor.sh to ensure the mandatory usage of cookies.

And I have add the support for arm64 images, which I believe will greatly benefit M1 users. Although I lack the necessary hardware to test the arm image, I think that it should function properly. It would be ideal if someone else could do a test.

I noticed that it was exactly two years ago since my last commit. I just rewrote it on a whim today, which was a coincidence.😆

- Update the `checkout` action to version 4
- Update the `metadata-action` to version 5
- Add the `setup-qemu` action
- Add the `setup-buildx` action
- Update the `login-action` to version 3 for DockerHub and GitHub Container Registry
- Update the `build-push-action` to version 5 and add `target` and `platforms` options

Signed-off-by: 陳鈞 <[email protected]>
@Ryu1845
Copy link
Collaborator

Ryu1845 commented Dec 21, 2023

Haha, congrats. LGTM

@Ryu1845 Ryu1845 merged commit dac047d into HoloArchivists:main Dec 21, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants