fix: Serialize Geraetemerkmal WITH GAS_ prefix in STJ (instead of w/o) (on v0.8.x legacy branch)
#619
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@hf-fvesely nach dem mergen bitte ein release 0.8.8 auf dem entsprechenden branch erstellen so kriegst du die fixes in die services ohne direkt die minor version auf 0.20 zu bumpen. |
hf-fvesely
reviewed
Dec 4, 2024
| @@ -120,6 +142,21 @@ public void TestSystemText_Success_NonNullable() | |||
| result.Merkmal.Should().Be(Geraetemerkmal.GAS_G4); | |||
There was a problem hiding this comment.
Hier ist noch eine Verwirrung zwischen gas und wasser
There was a problem hiding this comment.
ne, da kommt nur die github ansicht nicht drauf klar.
der test hat nichts mit wasser zu tun.
hf-fvesely
approved these changes
Dec 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this cherrypicks the changes from #618 to the v0.8.x legacy branch (used in 2 of our services ;))