Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set upper limit on version of nbconvert #215

Merged
merged 16 commits into from
Feb 8, 2024
Merged
Show file tree
Hide file tree
Changes from 5 commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 14 additions & 3 deletions .github/workflows/testing.yml
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,7 @@ jobs:
include:

- name: Documentation
python: '3.10'
python: '3.12'

steps:

Expand All @@ -88,8 +88,19 @@ jobs:
- name: Install nox
run: python -m pip install --progress-bar off --upgrade nox

- name: Install graphviz and pandoc
run: sudo apt install graphviz pandoc
- name: Install graphviz
run: sudo apt install graphviz

- name: Install pandoc
run: |
# Specify the desired version of Pandoc
PANDOC_VERSION="3.1.11.1" # Update this to the version you need
# Download the pre-built binary package for Linux
wget https://github.com/jgm/pandoc/releases/download/${PANDOC_VERSION}/pandoc-${PANDOC_VERSION}-1-amd64.deb
# Install the downloaded package
sudo dpkg -i pandoc-${PANDOC_VERSION}-1-amd64.deb
# Remove the downloaded package file
rm pandoc-${PANDOC_VERSION}-1-amd64.deb
Copy link
Contributor Author

@namurphy namurphy Feb 2, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hm...updating to the most recent release of pandoc still leads to the same error.

I got this step with help from ChatGPT.


- name: Build documentation
run: nox -e build_docs_nitpicky -- -q
Expand Down
1 change: 1 addition & 0 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -81,6 +81,7 @@ target/
# IPython
profile_default/
ipython_config.py
Untitled*.ipynb

# pyenv
.python-version
Expand Down
10 changes: 1 addition & 9 deletions docs/notebooks/data_analysis/Deconvolving_XRT_images.ipynb
Original file line number Diff line number Diff line change
Expand Up @@ -98,14 +98,6 @@
"fig.subplots_adjust(wspace=0.5)\n",
"plt.show()"
]
},
{
"cell_type": "code",
"execution_count": null,
"id": "549d08ea",
"metadata": {},
"outputs": [],
"source": []
}
],
"metadata": {
Expand All @@ -124,7 +116,7 @@
"name": "python",
"nbconvert_exporter": "python",
"pygments_lexer": "ipython3",
"version": "3.11.0"
"version": "3.12.1"
namurphy marked this conversation as resolved.
Show resolved Hide resolved
}
},
"nbformat": 4,
Expand Down
12 changes: 2 additions & 10 deletions docs/notebooks/data_analysis/Remove_lightleak.ipynb
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
"id": "075bbcc4",
"metadata": {},
"source": [
"# Using the remove_lightleak function to analyze XRT composite images"
"# Remove lightleaks to analyze XRT composite images"
namurphy marked this conversation as resolved.
Show resolved Hide resolved
]
},
{
Expand Down Expand Up @@ -131,14 +131,6 @@
"fig.subplots_adjust(wspace=0.5)\n",
"plt.show()"
]
},
{
"cell_type": "code",
"execution_count": null,
"id": "eda9e234",
"metadata": {},
"outputs": [],
"source": []
}
],
"metadata": {
Expand All @@ -157,7 +149,7 @@
"name": "python",
"nbconvert_exporter": "python",
"pygments_lexer": "ipython3",
"version": "3.11.0"
"version": "3.12.1"
namurphy marked this conversation as resolved.
Show resolved Hide resolved
}
},
"nbformat": 4,
Expand Down
Loading