Adding to @Jslavin Pr 207 - Add optional use of exposure maps to temperature_from_filter_ratio #207 #209
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The path to the model for hybrid abundances and photospheric abundances were switched.
Made atol scaled to temperature response to provide a more stringent test.
Made atol scaled to temperature response to provide a more stringent test.
Made atol scaled to temperature response to provide a more stringent test.
Made atol scaled to temperature response to provide a more stringent test.
Use atol and rtol values that should lead to passing all tests.
Use atol, rtol values that should lead to passing all tests.
Use atol, rtol values that should lead to passing all tests.
Use atol, rtol values that should lead to passing all tests.
needed to scale atol to max value of temperature response
need to scale atol to the max value of temperature response
for more information, see https://pre-commit.ci
…ak and xrt_deconvolve to that directory. Also moved associated tests and data
…tio. Also added fits keywords HGLN_OBS and HGLT_OBS to returned map metadata.
…er_ratio, which allows for proper usage of composite images.
…er_ratio, which allows for proper usage of composite images.
…for use with temperature_from_filter_ratio
…strating use of composite images with temperature_from_filter_ratio. Switched from using requests to using astropy.utils.data.download_file
…ile (Temperatue -> Temperature)
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
jslavin
approved these changes
Jan 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is an extension of PR #207 from @jslavin, aimed at addressing failing documentation tests. The original PR #207 likely introduced changes to the documentation that led to failing tests. This PR seeks to resolve those issues and ensure that the documentation is accurate and up-to-date.
Original initial PR comment:
"""Added the ability to use exposure maps (i.e. images in which each pixel contains the exposure time for the image data for the corresponding pixel) in the routine temperature_from_filter_ratio. This allows the use of composite images in which different pixels have different exposure times, generally used to combine long-short or long-medium-short image combinations in order to increase the dynamic range of images. Also the routine make_exposure_map was added to create the exposure maps for a given composite image. A routine filename2repo_path was added to the util directory to facilitate downloading the files necessary to create the exposure maps. And a notebook was created illustrating the use of these routines."""