Skip to content

Commit

Permalink
clarify value in right gain
Browse files Browse the repository at this point in the history
  • Loading branch information
wtbarnes committed Sep 8, 2024
1 parent 82f4c82 commit a708118
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 35 deletions.
2 changes: 2 additions & 0 deletions xrtpy/response/channel.py
Original file line number Diff line number Diff line change
Expand Up @@ -432,6 +432,8 @@ def ccd_gain_left(self) -> u.electron / u.DN:
@u.quantity_input
def ccd_gain_right(self) -> u.electron / u.DN:
"""Gain when reading the right port of the CCD."""
# NOTE: Value for the right gain in the instrument data files is incorrect.
# See https://github.com/HinodeXRT/xrtpy/pull/76
return u.Quantity(57.5, u.electron / u.DN)

@property
Expand Down
35 changes: 0 additions & 35 deletions xrtpy/response/tests/test_channel.py
Original file line number Diff line number Diff line change
Expand Up @@ -848,41 +848,6 @@ def test_channel_name2(channel_name):
assert name == IDL_mirror_name_AUTO


@pytest.mark.parametrize("channel_name", channel_names)
def test_channel_wavelength(channel_name):
channel_filter = Channel(channel_name)

wavelength_length = int(channel_filter.number_of_wavelengths)
wavelength = channel_filter.wavelength[:wavelength_length]

idl_array_length = int(
v6_genx_s[_channel_name_to_index_mapping[channel_name]]["LENGTH"]
)
idl_wavelength_auto = (
v6_genx_s[_channel_name_to_index_mapping[channel_name]]["WAVE"][
:idl_array_length
]
* u.angstrom
)

assert u.allclose(idl_wavelength_auto, wavelength)

idl_mirror_wavelength_manu = [
9.00000,
9.10000,
9.20000,
9.30000,
9.40000,
9.50000,
9.60000,
9.70000,
9.80000,
9.90000,
] * u.angstrom

assert u.allclose(idl_mirror_wavelength_manu, wavelength[80:90])


@pytest.mark.parametrize("channel_name", channel_names)
def test_channel_transmission(channel_name):
channel_filter = Channel(channel_name)
Expand Down

0 comments on commit a708118

Please sign in to comment.