Fix dai_link->cpus etc used without backing storage. #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jul 30, 2020
|
Thanks. I'll find time to look at this properly. |
|
I am not convinced this is completely correct, and I think it is partly the answer, or a good step towards it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ok, this is for v5.5. But I believe the problem is also present in the master and other branches. Commit 37a37a6 moved to "modern style dai_link". However, for doing so adi_link->cpus etc. needs to be provided with backing storage. This is not done automatically, at least not in 5.4. Please compare KERNEL/sound/soc/generic/simple-card-utils.c, function asoc_simple_init_priv(). Without this patch module loading immediately result in NULL-pointer dereference.