Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix SFTP Timeout Issue #1913

Merged
merged 9 commits into from
Aug 5, 2024
Merged

Fix SFTP Timeout Issue #1913

merged 9 commits into from
Aug 5, 2024

Conversation

JFriel
Copy link
Collaborator

@JFriel JFriel commented Aug 5, 2024

Proposed Change

Fix issue with SFTP timeout not being respected.
DLS has issue post-upgrade with SFTP timing out.
Fix adds SFTP specific checks, rather than using FTP checks and uses the overrides for connection timeouts as defined by the user

Type of change

What types of changes does your code introduce? Tick all that apply.

  • Bugfix (non-breaking change which fixes an issue)
  • New Feature (non-breaking change which adds functionality)
  • Breaking Change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation-Only Update
  • Other (if none of the other choices apply)

Checklist

By opening this PR, I confirm that I have:

  • Ensured that the PR branch is in sync with the target branch (i.e. it is automatically merge-able)
  • Created or updated any tests if relevant
  • Have validated this change against the Test Plan
  • Requested a review by one of the repository maintainers
  • Have written new documentation or updated existing documentation to detail any new or updated functionality and how to use it
  • Have added an entry into the changelog

@JFriel JFriel marked this pull request as ready for review August 5, 2024 10:04
@JFriel JFriel requested a review from jas88 August 5, 2024 10:04
@jas88 jas88 merged commit fda4b6b into develop Aug 5, 2024
7 checks passed
@jas88 jas88 deleted the bugfix/test-doug-ftp-timeout branch August 5, 2024 10:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants