feature/rc4 cleanup #1608
Merged
feature/rc4 cleanup #1608
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jas88
approved these changes
Aug 28, 2023
JFriel
added a commit
that referenced
this pull request
Aug 29, 2023
* resharper refactor * ui refactor from resharper * refactor tools from resharper * add fixes * remove dud file * attempt fix * revert db * add trust server to db yaml
jas88
added a commit
that referenced
this pull request
Aug 30, 2023
* Bump Terminal.Gui from 1.13.1 to 1.13.4 Bumps [Terminal.Gui](https://github.com/gui-cs/Terminal.Gui) from 1.13.1 to 1.13.4. - [Release notes](https://github.com/gui-cs/Terminal.Gui/releases) - [Commits](gui-cs/Terminal.Gui@v1.13.1...v1.13.4) --- updated-dependencies: - dependency-name: Terminal.Gui dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> * Bump Terminal.Gui from 1.13.4 to 1.13.5 Bumps [Terminal.Gui](https://github.com/gui-cs/Terminal.Gui) from 1.13.4 to 1.13.5. - [Release notes](https://github.com/gui-cs/Terminal.Gui/releases) - [Commits](gui-cs/Terminal.Gui@v1.13.4...v1.13.5) --- updated-dependencies: - dependency-name: Terminal.Gui dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> * Bump svenstaro/upload-release-action from 2.6.1 to 2.7.0 Bumps [svenstaro/upload-release-action](https://github.com/svenstaro/upload-release-action) from 2.6.1 to 2.7.0. - [Release notes](https://github.com/svenstaro/upload-release-action/releases) - [Changelog](https://github.com/svenstaro/upload-release-action/blob/master/CHANGELOG.md) - [Commits](svenstaro/upload-release-action@2.6.1...2.7.0) --- updated-dependencies: - dependency-name: svenstaro/upload-release-action dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> * Bump NLog from 5.2.2 to 5.2.3 Bumps [NLog](https://github.com/NLog/NLog) from 5.2.2 to 5.2.3. - [Release notes](https://github.com/NLog/NLog/releases) - [Changelog](https://github.com/NLog/NLog/blob/dev/CHANGELOG.md) - [Commits](NLog/NLog@v5.2.2...v5.2.3) --- updated-dependencies: - dependency-name: NLog dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> * Bump Microsoft.NET.Test.Sdk from 17.6.3 to 17.7.0 Bumps [Microsoft.NET.Test.Sdk](https://github.com/microsoft/vstest) from 17.6.3 to 17.7.0. - [Release notes](https://github.com/microsoft/vstest/releases) - [Changelog](https://github.com/microsoft/vstest/blob/main/docs/releases.md) - [Commits](microsoft/vstest@v17.6.3...v17.7.0) --- updated-dependencies: - dependency-name: Microsoft.NET.Test.Sdk dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> * Feature/whitespaceetc (#1583) * Automated formatting and syntax clean * Match docs to source; whitespace unit test cleanup * Bump Moq from 4.18.4 to 4.20.1 Bumps [Moq](https://github.com/moq/moq) from 4.18.4 to 4.20.1. - [Release notes](https://github.com/moq/moq/releases) - [Changelog](https://github.com/moq/moq/blob/main/CHANGELOG.md) - [Commits](moq/moq.spikes@v4.18.4...v4.20.1) --- updated-dependencies: - dependency-name: Moq dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> * Bump shogo82148/actions-setup-perl from 1.23.0 to 1.23.1 Bumps [shogo82148/actions-setup-perl](https://github.com/shogo82148/actions-setup-perl) from 1.23.0 to 1.23.1. - [Release notes](https://github.com/shogo82148/actions-setup-perl/releases) - [Commits](shogo82148/actions-setup-perl@v1.23.0...v1.23.1) --- updated-dependencies: - dependency-name: shogo82148/actions-setup-perl dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> * Feature/rdmp 13 removable default logging server (#1589) * make external serverremovable * no longer throwing out errors * add catalogue fix * added todo reminder * working startup option * remove fk drop * fix creation issue * add todo * working delete * invert checkbox ui * add throw for unexpected no logging server * rename variables to match descriptions * fix bad merge * fix autosave issue * Bump Moq from 4.20.1 to 4.20.2 Bumps [Moq](https://github.com/moq/moq) from 4.20.1 to 4.20.2. - [Release notes](https://github.com/moq/moq/releases) - [Changelog](https://github.com/moq/moq/blob/main/CHANGELOG.md) - [Commits](moq/moq.spikes@v4.20.1...v4.20.2) --- updated-dependencies: - dependency-name: Moq dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> * Add Clear User Settings Functionality (RDMP-7/GH#749) (#1586) * Add Clear User Settings button, command and unit test * Update SelfCertifyingDataAccessPoint.cs - Fix typo --------- Co-authored-by: jas88 <[email protected]> * Update UserSettings.cs Merge fixup * Bump Moq from 4.20.2 to 4.20.69 Bumps [Moq](https://github.com/moq/moq) from 4.20.2 to 4.20.69. - [Release notes](https://github.com/moq/moq/releases) - [Changelog](https://github.com/moq/moq/blob/main/CHANGELOG.md) - [Commits](moq/moq.spikes@v4.20.2...v4.20.69) --- updated-dependencies: - dependency-name: Moq dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> * Bump actions/setup-node from 3.7.0 to 3.8.0 Bumps [actions/setup-node](https://github.com/actions/setup-node) from 3.7.0 to 3.8.0. - [Release notes](https://github.com/actions/setup-node/releases) - [Commits](actions/setup-node@v3.7.0...v3.8.0) --- updated-dependencies: - dependency-name: actions/setup-node dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> * Bump YamlDotNet from 13.1.1 to 13.2.0 Bumps [YamlDotNet](https://github.com/aaubry/YamlDotNet) from 13.1.1 to 13.2.0. - [Release notes](https://github.com/aaubry/YamlDotNet/releases) - [Commits](aaubry/YamlDotNet@v13.1.1...v13.2.0) --- updated-dependencies: - dependency-name: YamlDotNet dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> * Bump SixLabors.ImageSharp.Drawing from 1.0.0-beta15 to 1.0.0 Bumps [SixLabors.ImageSharp.Drawing](https://github.com/SixLabors/ImageSharp.Drawing) from 1.0.0-beta15 to 1.0.0. - [Release notes](https://github.com/SixLabors/ImageSharp.Drawing/releases) - [Commits](SixLabors/ImageSharp.Drawing@v1.0.0-beta15...v1.0.0) --- updated-dependencies: - dependency-name: SixLabors.ImageSharp.Drawing dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> * start to update tests * compiling tests * tidy up unused * attempt to fix some tests * update tests * update ui tests * remove moq * fix up tests * fix up test * fix test * update tests * tidy up code * Bump actions/setup-node from 3.8.0 to 3.8.1 Bumps [actions/setup-node](https://github.com/actions/setup-node) from 3.8.0 to 3.8.1. - [Release notes](https://github.com/actions/setup-node/releases) - [Commits](actions/setup-node@v3.8.0...v3.8.1) --- updated-dependencies: - dependency-name: actions/setup-node dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> * Bump Microsoft.NET.Test.Sdk from 17.7.0 to 17.7.1 Bumps [Microsoft.NET.Test.Sdk](https://github.com/microsoft/vstest) from 17.7.0 to 17.7.1. - [Release notes](https://github.com/microsoft/vstest/releases) - [Changelog](https://github.com/microsoft/vstest/blob/main/docs/releases.md) - [Commits](microsoft/vstest@v17.7.0...v17.7.1) --- updated-dependencies: - dependency-name: Microsoft.NET.Test.Sdk dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> * Bump Autoupdater.NET.Official from 1.8.3 to 1.8.4 Bumps [Autoupdater.NET.Official](https://github.com/ravibpatel/AutoUpdater.NET) from 1.8.3 to 1.8.4. - [Release notes](https://github.com/ravibpatel/AutoUpdater.NET/releases) - [Commits](ravibpatel/AutoUpdater.NET@v1.8.3...v1.8.4) --- updated-dependencies: - dependency-name: Autoupdater.NET.Official dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> * Redo ProgressLog handling (#1603) * Update DataLoadInfo.cs - Implement worker thread for writing ProgressLog entries in background --------- Co-authored-by: James A Sutherland <> Co-authored-by: James Friel <[email protected]> * backout incorrect change * Bump VPKSoft.ScintillaLexers.NET from 1.1.15 to 1.1.16 Bumps [VPKSoft.ScintillaLexers.NET](https://github.com/VPKSoft/ScintillaLexers) from 1.1.15 to 1.1.16. - [Release notes](https://github.com/VPKSoft/ScintillaLexers/releases) - [Commits](https://github.com/VPKSoft/ScintillaLexers/commits) --- updated-dependencies: - dependency-name: VPKSoft.ScintillaLexers.NET dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> * Update LoadDirectory.cs Fix typo * Feature/rdmp 18 remove moq (#1602) * start to update tests * compiling tests * tidy up unused * attempt to fix some tests * update tests * update ui tests * remove moq * fix up tests * fix up test * fix test * update tests * tidy up code * backout incorrect change --------- Co-authored-by: James A Sutherland <[email protected]> * Feature/RDMP-28 Add BeginLoadData & EndLoadData to Datatables (#1598) * partial fix * add row peaker update * fix up whitespace * add a lot of daat begin loads * more data load * fix typo * RDMP-16 Add Max Message Length Check to Logging Notifications (#1595) * add message length check * fix tabbing * fix codescan alert * update max length and add env config * attempt to allow RDMP_ * fix typo * add codeql update * Update ToLoggingDatabaseDataLoadEventListener.cs Adjust string trimming logic, handle ultra-short limits, only parse the environment variable once instead of per logging, avoid double-lookup in OnProgress handler --------- Co-authored-by: James A Sutherland <[email protected]> * Bump YamlDotNet from 13.2.0 to 13.3.1 (#1611) Bumps [YamlDotNet](https://github.com/aaubry/YamlDotNet) from 13.2.0 to 13.3.1. - [Release notes](https://github.com/aaubry/YamlDotNet/releases) - [Commits](aaubry/YamlDotNet@v13.2.0...v13.3.1) --- updated-dependencies: - dependency-name: YamlDotNet dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Typo and syntax fixes * syntax fixes * Remove CheckForVersionMismatches, no longer needed * Update DocumentationCrossExaminationTest.cs Adjust ignorelist - AppData is a system file path not a piece of code * Update DatabaseTests.cs Need to initialise MSSQL driver in Fansi before configuring it! * Fix flatfileattacher circularity * Test typo fixes * Syntax cleanups * Create directory.build.props * Fix plugin version check code * Better plugin load failure debugging * Better plugin load error reporting * Plugin work Add Mongo for plugin use, document * Update ExecuteCommandPrunePlugin.cs Make plugin pruning more informative, enforce managed-only * Update ExecuteCommandPrunePlugin.cs Remove native dependencies instead of rejecting - too hard to avoid inclusion in build * Update Startup.cs Add DLL load failure debugging * Update LoadModuleAssembly.cs Reset MemoryStream after reading * Syntax tidy, simplify PersistStringHelper * Syntax, duplicate dictionary lookups * Booleans and args.Empty * Fix infinite loop in time window checker, LINQ cleanup * Tidy up ObjectConstructor and usage * Syntax, pattern matching * Compile fix, remove redundancies * Syntax cleanups Type specifiers, commas in lists * Final syntax cleanup private/internal modifiers * Redundancies, unnecessary generics * Build and syntax fixes * Tune ColumnForbidder * Fix Microsoft.NET.Test.Sdk versioning * System.Resources.Extensions version mismatch * API and naming fixups * Update DatabaseTests.cs Workaround for FAnsi missing OperationCanceledException * ANOTable recursion fix * Update DatabaseTests.cs Explicit variable init * Update DatabaseTests.cs Temporary workaround for FAnsi not catching OperationCanceledException * Update UnitTests.cs Fix recursion on WhenIHaveA ObjectExport * Adjust docs, date bound checking, validation serialisation * Cleanup, better logging in startup reflection * RC4 Add Terminal.Gui to Win front end for compatibility with plugins * String interp * Syntax, pattern matching * Make IgnoreAllErrorsCheckNotifier singleton, fix MEF event issue * Update IgnoreAllErrorsCheckNotifier.cs Bite the bullet and force singleton mode * Syntax clean * Fixup ThrowImmediatelyCheckNotifier.Quiet() * Remove unit test for obsolete method * Refactor MEF * Update ConsoleInputManager.cs API fixup * Syntax, MEF * Syntax * Update ProposeExecutionWhenTargetIsLoadStageNode.cs Fix missing f * Syntax clean * Type checking fix * MEF caching, distincting * Regexes, .Net 7 * API fixup for .Net 7 internal changes * Prune all non-DLLs in plugins * Syntax cleaning * Pattern matching * Cleanup * Coalesce * Update ExecuteCommandPrunePlugin.cs Fix pruning logic to protect .nuspec files * Cleanup, dependency update * Cleanup * MEF adjustments * Fix Lazy MEF init * Update QueryCachingCrossServerTests.cs Acknowledge that MySQL does have EXCEPT queries now * Compound assignments * Syntax * Dictionary Avoid double-lookups in dictionary types * Null propogation * Null coalesce * Regexes * Docs fixup * Syntax cleanup, remove old DWM check (Win7 only) * Tidy XML handling * Whitespace cleanup * Update DbDataCommandDataFlowSource.cs Cache schema chunk and clone as needed, begin/end dataload explicitly * Update Packages.md Add missing entry for XMLSerializer generator * Update DataLoadInfo.cs Deconflict ProgressEventType XML tag * Dispose of MEF references everywhere * Update WebFileDownloader.cs Longer timeout, copy to destination before disposing of request objects * Update ResearchDataManagementPlatform.csproj Clean up output directory pollution * Post merge cleanup - duplicate lines, statics, inlining variables * Add Equ, remote old Xam settings plugin * Update LogManager.cs Load ProgressLog without locking to reduce deadlock risks * Specify string comparison locale * Update Startup.cs Read plugins from exe directory not db * Update LoadModuleAssembly.cs Enforce seekability on plugin files * Update IPluginManager.cs Namespace fix, docxml was incorrectly referencing a third party Plugin object not the RDMP object of that name * Static methods where applicable * Remove SetupMEF, no longer needed * More readonly fields * Whitespace and typo fixes * Update UsefulStuff.cs Fix BaseDirectory access, avoid Assembly.Location entirely since compiler objects now * Statics, readonly * Format fixups * Pattern matching * Whitespace, sealed classes * Format, auto cleanup * Docs fixup; allow non-public constructors for reflection-invoked classes * Static and string cleanup * Typos and string diff fixups * Update DataFlowPipelineContext.cs Debug across invoke boundary a bit * Make ProgressLog timeout 1 hour - insane for single-row inserts, but 2 minutes is still too short... * Update plugin pack to install to right place * Move Terminal.Gui to Core rather than duplicating both CLI and GUI refs * Implement async writer thread for ProgressLog * Flush log queue unconditionally, even on duplicate DataLoadInfo closes. * Bugfix: load Win code only in GUI mode, instead of whenever running in WinNT * Disused files * Add alias for mistyped Nullity predictor * Stray newline * Update ValuePredictsOtherValueNullity.cs Workaround legacy ValuePredictsOtherValueNullness name * Format cleanup * Tidyup * feature/rc4 cleanup (#1608) * resharper refactor * ui refactor from resharper * refactor tools from resharper * add fixes * remove dud file * attempt fix * revert db * add trust server to db yaml * bugfix/RDMP 31 extraction delect ui issue (#1609) * fix extraction ui crash * attempt build fix * revert build issue * repoint test db * remove ampersands * commend out hang * bump version * uncomment * replace cat with sed * update build * fix command hang issue * add close * revert changes * update sripts * tidy up --------- Co-authored-by: James A Sutherland <[email protected]> * partial fix * passing build * fixup * more bad merge fix * fix explicit disallow --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: James A Sutherland <[email protected]> Co-authored-by: James A Sutherland <>
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merge of develop back into rc4 to fix the rather large merge issue.
Uses Resharper cleanup tool