Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revamp Library: Improve Interfaces and Fix Functionality #136

Merged
merged 1 commit into from
Mar 21, 2024

Conversation

maxlambrecht
Copy link
Collaborator

This PR enhances the library's functionality and user experience.

Major enhancements include:

  • Addressed issues with X509BundleSet and JwtBundleSet types to ensure they function as intended.
  • Refactored SpiffeId and TrustDomain types to utilize __init__ constructors, streamlining the code in line with Pythonic standards.
  • Transitioned getter methods to use the @property decorator, facilitating more straightforward attribute access.
  • Updated method names for better clarity and usability in the library's public API.
  • Expanded and refined test coverage for more robust validation.
  • Integrated a check for the SPIFFE socket path in the Workload API client, preventing indefinite hangs and facilitating quicker error feedback.
  • Updated workload.proto to reflect the latest specifications and regenerated protobuf code.

These changes aim to improve reliability, readability, and ease of use.

@maxlambrecht maxlambrecht merged commit 49189c6 into HewlettPackard:main Mar 21, 2024
6 checks passed
@maxlambrecht maxlambrecht deleted the revamp-library branch March 21, 2024 21:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant