-
-
Notifications
You must be signed in to change notification settings - Fork 450
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement a basic URL scheme. #308
Implement a basic URL scheme. #308
Conversation
Maybe to test you just need to put |
Everything is broken. Fml. |
@flavioislima this is ready to be merged, but problem is that the frontend has no idea what just happened. I'll make the backend state-aware and the client can just query it. Would also reduce the global state. That'll might have to be a seperate PR tho. |
95432d6
to
b51fe0b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. I'm just not 100% on the user confirmation because if the desktop file will be clicked, then I think it was on porpuse. Steam and lutris don't ask for confirmation for instance. So I think this might not be necessary. But merge it and we can think about that before release.
I'm not either, but I did it just in case as its easier to remove something than to implement it pre-release. |
Fixes #307.
Implementation based on what I read here:
electron-userland/electron-builder#4035
electron/electron#4857
Scheme is a lot like HTTP, except that there's no domain name.
Like
heroic://launch?appName=Hazelnut
.