Fix reproduceskill and cloneskill being used in checks when being zero #3322
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This resulted in for example skills gained temporarily by equipping which used SKILL_FLAG_REPLACED_LV_* to be not cleared when taking the equip off.
MishimaHaruna
approved these changes
Sep 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Prelude
Changes Proposed
Fix reproduceskill and cloneskill being used in checks when being zero
This resulted in for example skills gained temporarily by equipping which used SKILL_FLAG_REPLACED_LV_* to be not cleared when taking the equip off.
This bug was introduced in #3298
NOTE: It's debatable if the loop that recreates skill levels of SKILL_FLAG_REPLACED_LV_* and SKILL_FLAG_TEMPORARY skills should be part of pc->calc_skilltree_clear(..) as well. But that's refactoring and not in the scope of this PR.
Issues addressed: None