Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

2-2 jobs skill rebalance - Bard/Dancer (2018 Patch/Renewal) #3279

Merged
merged 30 commits into from
Jun 30, 2024
Merged

2-2 jobs skill rebalance - Bard/Dancer (2018 Patch/Renewal) #3279

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
30 commits
Select commit Hold shift + click to select a range
9362328
Add song groups for Bard/Dancer songs (RE-only)
guilherme-gm Nov 19, 2023
5bcff7d
Rebalance of BA_MUSICALSTRIKE (Melody Strike) and DC_THROWARROW (Slin…
guilherme-gm Aug 30, 2020
23b2ab1
Rebalance of BA_MUSICALLESSON (Music Lessons)
guilherme-gm Nov 19, 2023
785a3a1
Rebalance of DC_DANCINGLESSON (Dance Lessons)
guilherme-gm Nov 19, 2023
9b6bcf9
Rebalance of BA_FROSTJOKE (Unbarring Octave)
guilherme-gm Nov 19, 2023
ef6b628
Rebalance of BD_ENCORE (Encore)
guilherme-gm Nov 19, 2023
45e6b30
Rebalance of BA_DISSONANCE (Unchained Serenade)
guilherme-gm Nov 19, 2023
b3786a6
Rebalance of BA_POEMBRAGI (Magic Strings)
guilherme-gm Nov 19, 2023
332f40f
Rebalance of BA_ASSASSINCROSS (Impressive Riff)
guilherme-gm Nov 19, 2023
252c90c
Rebalance of BA_APPLEIDUN (Song of Lutie)
guilherme-gm Nov 19, 2023
c1f448c
Rebalance of BA_WHISTLE (Perfect Tablature)
guilherme-gm Nov 19, 2023
4af0255
Rebalance of DC_UGLYDANCE (Hip Shaker)
guilherme-gm Nov 19, 2023
91bf1e3
Rebalance of DC_DONTFORGETME (Slow Grace)
guilherme-gm Nov 19, 2023
7cb88f8
Rebalance of DC_SERVICEFORYOU (Gypsy's Kiss)
guilherme-gm Nov 19, 2023
01dacf3
Rebalance of DC_FORTUNEKISS (Lady Luck)
guilherme-gm Nov 19, 2023
29ec605
Rebalance of DC_HUMMING (Focus Ballet)
guilherme-gm Nov 19, 2023
2fd9dd0
Change general effect of performing ensembles (RE-only)
guilherme-gm Nov 19, 2023
0dc17bb
Change pc_gainexp "is_quest" to a bitmask enum
guilherme-gm Feb 7, 2024
ff2a231
Rebalance of BD_RICHMANKIM (Mental Sensing)
guilherme-gm Nov 19, 2023
46f4576
Rebalance of BD_RINGNIBELUNGEN (Harmonic Lick)
guilherme-gm Nov 19, 2023
83c98c7
Rebalance of BD_SIEGFRIED (Acoustic Rhythm)
guilherme-gm Nov 19, 2023
1b1b837
Rebalance of BD_INTOABYSS (Power Chord)
guilherme-gm Nov 19, 2023
d883aa5
Rebalance of BD_ETERNALCHAOS (Down Tempo)
guilherme-gm Nov 19, 2023
49968fe
Rebalance of BD_ROKISWEIL (Classical Pluck)
guilherme-gm Jan 14, 2024
0e77504
Rebalance of BD_LULLABY (Lullaby)
guilherme-gm Nov 19, 2023
ccc9a0f
Rebalance of BD_DRUMBATTLEFIELD (Battle Theme)
guilherme-gm Nov 19, 2023
1853c68
Reformat BD_ADAPTION interrupt checks
guilherme-gm Nov 19, 2023
6c751aa
Rebalance of BD_ADAPTATION (Amp)
guilherme-gm Nov 19, 2023
1560da7
Expand ensemble skills range to 4 cells (RE)
guilherme-gm Jan 20, 2024
95942f0
Remove special dispell logic for songs in RE
guilherme-gm Feb 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 23 additions & 3 deletions db/constants.conf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1271,7 +1271,7 @@ constants_db: {
SC_QD_SHOT_READY: 684
SC_HOWLING_MINE: 685
SC_BIND_TRAP: 686

// Star Emperor
SC_SUNSTANCE: 687
SC_STARSTANCE: 688
Expand Down Expand Up @@ -1307,7 +1307,7 @@ constants_db: {
SC_SOULDIVISION: 716

SC_ACTIVE_MONSTER_TRANSFORM: 717

SC_FIRE_EXPANSION_TEAR_GAS_SOB: 718

SC_TAROTCARD_ATK_PERC: 719
Expand All @@ -1316,7 +1316,10 @@ constants_db: {
SC_GOSPEL_ATK_PERC: 722

SC_NO_SWITCH_WEAPON: 723


SC_ENSEMBLEFATIGUE: 724
SC_ADAPTATION: 725

comment__: "Emotes"
e_gasp: 0
e_what: 1
Expand Down Expand Up @@ -4307,6 +4310,21 @@ constants_db: {
SI_DEFENDER: 62
SI_AUTOSPELL: 65
SI_SPEARQUICKEN: 68
SI_WHISTLE: 70
SI_ASSASSINCROSS: 71
SI_POEMBRAGI: 72
SI_APPLEIDUN: 73
SI_HUMMING: 74
SI_DONTFORGETME: 75
SI_FORTUNEKISS: 76
SI_SERVICEFORYOU: 77
SI_RICHMANKIM: 78
SI_ETERNALCHAOS: 79
SI_DRUMBATTLEFIELD: 80
SI_RINGNIBELUNGEN: 81
SI_ROKISWEIL: 82
SI_INTOABYSS: 83
SI_SIEGFRIED: 84
SI_EXPLOSIONSPIRITS: 86
SI_STEELBODY: 87
SI_EXTREMITYFIST: 88
Expand Down Expand Up @@ -4926,6 +4944,8 @@ constants_db: {
SI_USE_SKILL_SP_SPA: 1062
SI_USE_SKILL_SP_SHA: 1063
SI_SP_SHA: 1064
SI_ENSEMBLEFATIGUE: 1088
SI_ADAPTATION: 1089
SI_SOULCURSE: 1125
SI_MADOGEAR: 1149
}
26 changes: 26 additions & 0 deletions db/pre-re/sc_config.conf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6450,3 +6450,29 @@ SC_NO_SWITCH_WEAPON: {
}
Icon: "SI_NOEQUIPWEAPON"
}

SC_ENSEMBLEFATIGUE: {
Visible: true
Flags: {
NoSave: true
NoDispelReset: true
NoBBReset: true
NoClearanceReset: true
Debuff: true
}
CalcFlags: {
Speed: true
Aspd: true
}
Icon: "SI_ENSEMBLEFATIGUE"
}

SC_ADAPTATION: {
Visible: true
Flags: {
Buff: true
NoMadoReset: true
NoMagicBlocked: true
}
Icon: "SI_ADAPTATION"
}
22 changes: 11 additions & 11 deletions db/pre-re/skill_db.conf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9150,7 +9150,7 @@ skill_db: (
DamageType: {
NoDamage: true
}
SkillData2: 5000
SkillData2: 5_000 // Time near start/end of performance where it is not possible to cancel (in miliseconds)
CoolDown: 0
Requirements: {
SPCost: 1
Expand Down Expand Up @@ -9651,8 +9651,8 @@ skill_db: (
DamageType: {
NoDamage: true
}
SkillData1: 60000
SkillData2: 20000
SkillData1: 60_000 // Duration of the performance (in miliseconds)
SkillData2: 20_000 // Duration of SC_WHISTLE when unit leaves the performance area (in miliseconds)
CoolDown: 0
Requirements: {
SPCost: {
Expand Down Expand Up @@ -9702,8 +9702,8 @@ skill_db: (
DamageType: {
NoDamage: true
}
SkillData1: 120000
SkillData2: 20000
SkillData1: 120_000 // Duration of the performance (in miliseconds)
SkillData2: 20_000 // Duration of SC_ASSNCROS when unit leaves the performance area (in miliseconds)
CoolDown: 0
Requirements: {
SPCost: {
Expand Down Expand Up @@ -9753,8 +9753,8 @@ skill_db: (
DamageType: {
NoDamage: true
}
SkillData1: 180000
SkillData2: 20000
SkillData1: 180_000 // Duration of the performance (in miliseconds)
SkillData2: 20_000 // Duration of SC_POEMBRAGI when unit leaves the performance area (in miliseconds)
CoolDown: 0
Requirements: {
SPCost: {
Expand Down Expand Up @@ -9804,8 +9804,8 @@ skill_db: (
DamageType: {
NoDamage: true
}
SkillData1: 180000
SkillData2: 20000
SkillData1: 180_000 // Duration of the performance (in miliseconds)
SkillData2: 20_000 // Duration of SC_APPLEIDUN when unit leaves the performance area (in miliseconds)
CoolDown: 0
Requirements: {
SPCost: {
Expand Down Expand Up @@ -9980,8 +9980,8 @@ skill_db: (
DamageType: {
NoDamage: true
}
SkillData1: 60000
SkillData2: 20000
SkillData1: 60_000 // Duration of the performance (in miliseconds)
SkillData2: 20_000 // Duration of SC_HUMMING when unit leaves the performance area (in miliseconds)
CoolDown: 0
Requirements: {
SPCost: {
Expand Down
10 changes: 10 additions & 0 deletions db/re/map_zone_db.conf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,6 +116,11 @@ zones: (
WM_SATURDAY_NIGHT_FEVER: "PLAYER"
SO_ARRULLO: "PLAYER"
CG_HERMODE: "PLAYER"
BA_DISSONANCE: "PLAYER"
DC_UGLYDANCE: "PLAYER"
DC_DONTFORGETME: "PLAYER"
BD_ETERNALCHAOS: "PLAYER"
BD_ROKISWEIL: "PLAYER"
}

disabled_items: {
Expand Down Expand Up @@ -514,6 +519,11 @@ zones: (
SC_MANHOLE: "PLAYER"
WM_POEMOFNETHERWORLD: "PLAYER"
GN_WALLOFTHORN: "PLAYER"
BA_DISSONANCE: "PLAYER"
DC_UGLYDANCE: "PLAYER"
DC_DONTFORGETME: "PLAYER"
BD_ETERNALCHAOS: "PLAYER"
BD_ROKISWEIL: "PLAYER"
}

disabled_items: {
Expand Down
Loading
Loading