Fix memory leaks of emblem_data #3278
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4144
approved these changes
Jan 27, 2024
…d emblem_data without freeing first
skyleo
force-pushed
the
emblem-memory-leaks
branch
from
780cfff to
ad7b9e8
Compare
|
Removed the unnecessary null check before freeing. (when you free a null pointer nothing happens) |
MishimaHaruna
approved these changes
Feb 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Prelude
Changes Proposed
Fix memory leaks of emblem_data caused by not freeing them when unloading guilds in char-server or disbanding them.
Also caused in map-server when receiving guild info from a guild that is already inside the map-server guild_db overwriting the emblem_data without freeing it first.
Issues addressed: None surprisingly.