Fix clif->pLoadEndAck being called in pc->scdata_received before receiving client's loadendack #3277
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Prelude
Changes Proposed
Don't unnecessarily call clif->pLoadEndAck, when we're receiving scdata and everything else from char to map in time.
in the following part I will talk about behavior before the changes this PR introduces:
As in don't call clif->pLoadEndAck manually if you haven't even received it from the client yet aka client didn't finish loading
Also yes we will get past the various checks if everything happened in time on server-side (as in the stuff we waiting from char-server to receive).
If we login fresh sd->bl.prev will be NULL for example.
So if we call clif->pLoadEndAck in this scenario, we will send data to the client and set data before the client actually finished loading.
Issues addressed: None?