Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix clif->pLoadEndAck being called in pc->scdata_received before receiving client's loadendack #3277

Merged

Conversation

skyleo
Copy link
Contributor

@skyleo skyleo commented Jan 26, 2024

Pull Request Prelude

Changes Proposed

Don't unnecessarily call clif->pLoadEndAck, when we're receiving scdata and everything else from char to map in time.

in the following part I will talk about behavior before the changes this PR introduces:

As in don't call clif->pLoadEndAck manually if you haven't even received it from the client yet aka client didn't finish loading

Also yes we will get past the various checks if everything happened in time on server-side (as in the stuff we waiting from char-server to receive).

If we login fresh sd->bl.prev will be NULL for example.

So if we call clif->pLoadEndAck in this scenario, we will send data to the client and set data before the client actually finished loading.

Issues addressed: None?

@skyleo skyleo changed the base branch from stable to master January 26, 2024 21:46
@MishimaHaruna MishimaHaruna added this to the Release v2024.02 milestone Feb 4, 2024
@MishimaHaruna MishimaHaruna merged commit eb142b5 into HerculesWS:master Feb 5, 2024
216 of 256 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants