-
Notifications
You must be signed in to change notification settings - Fork 759
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add script function to work with item_group #3275
Merged
MishimaHaruna
merged 7 commits into
HerculesWS:master
from
lucasgolino:feat/getitemgroupitems_script
Apr 30, 2024
Merged
Add script function to work with item_group #3275
MishimaHaruna
merged 7 commits into
HerculesWS:master
from
lucasgolino:feat/getitemgroupitems_script
Apr 30, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
reviewed
Jan 21, 2024
ghost
reviewed
Jan 21, 2024
ghost
reviewed
Jan 21, 2024
ghost
reviewed
Jan 21, 2024
ghost
reviewed
Jan 21, 2024
ghost
reviewed
Jan 21, 2024
MishimaHaruna
requested changes
Feb 4, 2024
Co-authored-by: Evil Puncker <[email protected]>
Signed-off-by: Haru <[email protected]>
Signed-off-by: Haru <[email protected]>
MishimaHaruna
force-pushed
the
feat/getitemgroupitems_script
branch
from
April 30, 2024 18:03
f175020
to
7cbc70c
Compare
MishimaHaruna
approved these changes
Apr 30, 2024
skyleo
requested changes
Apr 30, 2024
- Memory leak in the deduplication function - Some unnecessary data copies in the search and deduplication function - Accidental overwrite of the original group's data in the deduplication function Signed-off-by: Haru <[email protected]>
MishimaHaruna
force-pushed
the
feat/getitemgroupitems_script
branch
from
April 30, 2024 20:22
13bb669
to
b665c4c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Prelude
Changes Proposed
This PR aims to create a script function to get all items without duplicated from a specific
group_id
. The idea behind this is be able to get all items and be capable to create more complex NPC with it. Ideal for this is: use more groups feature to handle with a list of group in a easiest way without needed to create arrays of a item listing all itens you need, and instead of it, use groups list as resource in NPC.In same PR i create an utilities tool set to clean duplicated from group in order to get only unique list from group.
Note: I add script command on
docs/script_commands.txt
Example: