Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix combo_cache_skill checking current skill delay instead of last one #3266

Merged
merged 1 commit into from
Dec 30, 2023
Merged

Fix combo_cache_skill checking current skill delay instead of last one #3266

merged 1 commit into from
Dec 30, 2023

Conversation

csnv
Copy link
Contributor

@csnv csnv commented Dec 30, 2023

Pull Request Prelude

Changes Proposed

Setting combo_cache_skill was checking current skill's delay instead of checking for the last combo skill that produced the current delay.

Issues addressed:

@MishimaHaruna MishimaHaruna added this to the Release v2023.12 milestone Dec 30, 2023
@MishimaHaruna MishimaHaruna merged commit be9baf5 into HerculesWS:master Dec 30, 2023
255 of 256 checks passed
@csnv csnv deleted the feature/combo-cache-skill branch January 19, 2024 02:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MishimaHaruna MishimaHaruna MishimaHaruna approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Release v2023.12
Development

Successfully merging this pull request may close these issues.
2 participants
@csnv @MishimaHaruna