Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use a single solution file for MVSC #3262

Merged
merged 1 commit into from
Dec 27, 2023
Merged

Use a single solution file for MVSC #3262

merged 1 commit into from
Dec 27, 2023

Conversation

csnv
Copy link
Contributor

@csnv csnv commented Dec 17, 2023

Pull Request Prelude

Changes Proposed

Use a single solution file for MVSC

Issues addressed:

@dastgirp
Copy link
Member

Debug folder is committed as well, I think that can be added in gitignore?

@csnv csnv force-pushed the feature/sln-cleanup branch from fdb4d1c to 573a26f Compare December 18, 2023 19:19
@csnv
Copy link
Contributor Author

csnv commented Dec 18, 2023

Debug folder is committed as well, I think that can be added in gitignore?

Whoopsie. Fixed, thanks!

@MishimaHaruna MishimaHaruna added this to the Release v2023.12 milestone Dec 27, 2023
@MishimaHaruna MishimaHaruna merged commit 3345da4 into HerculesWS:master Dec 27, 2023
214 of 256 checks passed
@guilherme-gm guilherme-gm mentioned this pull request Dec 30, 2023
Merged
3 tasks
@Asheraf
Copy link
Contributor

Asheraf commented Dec 30, 2023

@MishimaHaruna this seems to have deleted the following projects.. HPM cannot be built on windows now

plugin-HPMHooking_api.vcxproj
plugin-HPMHooking_char.vcxproj
plugin-HPMHooking_login.vcxproj
plugin-HPMHooking_map.vcxproj
plugin-sample.vcxproj

@csnv csnv mentioned this pull request Dec 30, 2023
Merged
3 tasks
@csnv
Copy link
Contributor Author

csnv commented Dec 30, 2023 •
edited
Loading

@MishimaHaruna this seems to have deleted the following projects.. HPM cannot be built on windows now

plugin-HPMHooking_api.vcxproj
plugin-HPMHooking_char.vcxproj
plugin-HPMHooking_login.vcxproj
plugin-HPMHooking_map.vcxproj
plugin-sample.vcxproj

My bad, I accidentally removed the last slash in .gitignore. Fixed in #3268

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MishimaHaruna MishimaHaruna MishimaHaruna approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Release v2023.12
Development

Successfully merging this pull request may close these issues.
4 participants
@csnv @dastgirp @Asheraf @MishimaHaruna