Added combo skill cache mechanic toggle #3260
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
approved these changes
Dec 4, 2023
Allows triggering a combo skill automatically if it was requested during an active combo skill delay
csnv
force-pushed
the
feature/combo-cache-skill
branch
from
40d5115 to
487d804
Compare
MishimaHaruna
requested changes
Dec 27, 2023
MishimaHaruna
approved these changes
Dec 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Prelude
Changes Proposed
Currently, combo skills can only be triggered in a small window of 300ms (by default) where SC_COMBOATTACK is active and the previous combo skill delay has terminated. This is the official behavior and makes triggering combo skills after hard delays quite difficult and unintuitive, specially if the user has latency problems.
This change adds a toggle that, if enabled, allows combo skill users to trigger combo skills automatically after the previous combo skill delay has finished if it was requested during its delay.
This optional behavior allows chaining combo skills more intuitive and easier, without bypassing delays or changing mechanics.
Issues addressed:
None.