Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix costumes blocking itemskills execution #3257

Merged
merged 1 commit into from
Dec 27, 2023

Conversation

csnv
Copy link
Contributor

@csnv csnv commented Nov 26, 2023

Pull Request Prelude

Changes Proposed

Fixes costumes blocking itemskills execution, even when items are being consumed.

Thanks to @skyleo and @guilherme-gm for the info regarding how costumes work in officials.

Issues addressed:
#2925 Partially, as there're two different issues being described in the comments.

@MishimaHaruna MishimaHaruna added this to the Release v2023.12 milestone Nov 28, 2023
@MishimaHaruna MishimaHaruna merged commit 9579794 into HerculesWS:master Dec 27, 2023
253 of 256 checks passed
@csnv csnv deleted the fix/costume_itemskill branch January 19, 2024 02:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants