Fix sc statuses not loaded on time when under heavy load #3256
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skyleo
reviewed
Nov 25, 2023
ghost
approved these changes
Nov 26, 2023
MishimaHaruna
requested changes
Dec 27, 2023
MishimaHaruna
approved these changes
Dec 28, 2023
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Prelude
Changes Proposed
Added a new flag to indicate sc data has been loaded and postpone clif->parse_LoadEndAck until all requirements are met.
When under heavy load, pc->reg_received runs before pc->scdata_received, thus invoking character calculation without taking any sc statuses like SC_PUSH_CART into consideration.
Along with incorrect character stats or substats, this issue makes the player not able to see visual effects or elements related to statuses, as well as the cart, until the player changes maps or uses a fly wing.
Issues addressed: