Added option to synchronize flinch animation with walk delay #3232
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
csnv
force-pushed
the
feature/walkdelay_sync
branch
from
7aca7bf to
527ef11
Compare
Interrupts walking and applies walk delay at the same time as the client reproduces the flinch animation. Improves positional lag.
csnv
force-pushed
the
feature/walkdelay_sync
branch
from
527ef11 to
6ad669d
Compare
MishimaHaruna
approved these changes
Oct 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Prelude
Changes Proposed
Currently, server iteration differs from client behavior when a target receives damage.
As of now, when a character is moving to X/Y and receives damage, clif_damage is invoked and the client reproduces the flinch animation shortly after, locking the character in place without reaching X/Y.
Server side the character is also stopped and a walk delay is applied, however the delay in which this happens is much larger than the one in the client, allowing the character to walk additional cells server side without the client being aware of this, causing positional lag and visual inconsistencies.
This change adds a macro option to apply the walk delay (and stopping the character) at a time relatively similar to the time the flinch animation is displayed client side.
Issues addressed:
None