Actions CI adjustments #3217
Merged
Actions CI adjustments #3217
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the current approach of using mysqladmin ping was failing all the time, using the healtcheck script contained in the container image should be enough, since it ensures the instance is reachable mysql containers still use mysqladmin ping (since healthcheck.sh is not available for them)
sometimes the test execution freezes but doesn't fail. Those tests usually take 30 minutes in the worst case, so using a timeout of 1 hour will prevent jobs from staying running for 6 hours until the default timeout stops them.
guilherme-gm
changed the title
MishimaHaruna
approved these changes
Jul 12, 2023
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Prelude
Changes Proposed
the current approach of using
mysqladmin pingis failing all the time, using the healtcheck script contained in the container image should be enough, since it ensures the instance is reachablemysql containers still use mysqladmin ping (since healthcheck.sh is not available for them)
from my tests, the issue about failing due to unhealthy MariaDB is fixed. There is still the rare occurrence of one container failing in the overall step, but restarting the specific one works.
After fixing MariaDB checks, I noticed that tests that starts/stops Hercules sometimes gets frozen and stays running until it reaches GitHub's default timeout (6 hours). Those jobs usually finish in 10 minutes, with a few exceptions that takes about 30 minutes.
I set their timeout to 1 hour, in case any of the tests end up locked they will fail in 1 hour instead of 6, saving a good amount of runner minutes.
Sample of it failling : https://github.com/guilherme-gm/Hercules/actions/runs/5502605147/jobs/10027096701
Issues addressed:
None