-
Notifications
You must be signed in to change notification settings - Fork 759
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update packets to 2022-05-18 #3142
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Asheraf
approved these changes
May 11, 2022
4144
force-pushed
the
updatepackets
branch
3 times, most recently
from
May 18, 2022 16:54
95d2d1a
to
cd0f85b
Compare
MishimaHaruna
approved these changes
Jun 1, 2022
New script command: setdialogsize
New script command: setdialogpos
…n position New script function setdialogpospercent.
Also add command playbgmall2 same as playbgmall but with type parameter.
Also add script command soundeffectall2 with term parameter.
Because before mode PLAY_SOUND_REPEAT was broken and worked as PLAY_SOUND_ONCE.
Look like false positives inside libconfig.
Also add enum with type values for packet ZC_BROADCASTING_SPECIAL_ITEM_OBTAIN
Signed-off-by: Haru <[email protected]>
MishimaHaruna
force-pushed
the
updatepackets
branch
from
June 2, 2022 02:51
b959985
to
012d719
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Prelude
Changes Proposed
Update shuffle packets and keys up to 2022-05-18.
Update messages up to 2022-05-18.
Add script commands
mes2
,next2
(support in client still incomplete) (main 20220405+).Add script commands for set npc dialog position:
setdialogpos
,setdialogpospercent
(main 20220405+).Add script command for set npc dialog size:
setdialogsize
(main 20220405+).Extend script command
playbgmall
with type parameter (main 20220405+).Add script command
playbgmall2
same withplaybgmall
but with type parameter (main 20220405+).Use item amount in packet ZC_INVENTORY_MOVE_FAILED.
Add term parameter into script command
soundeffect
.Add script command
soundeffectall2
same withsoundeffectall
but with term parameter (main 20220405+).Use constants for play type in
soundeffect
andsoundeffectall
.Fix repeat sound in packet PACKET_ZC_SOUND (script commands
soundeffect
,soundeffectall
)Update packet ZC_BROADCASTING_SPECIAL_ITEM_OBTAIN (for item obtain).
Update libbacktrace.
Update github ci configs.