Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update packets to 2022-05-18 #3142

Merged
merged 50 commits into from
Jun 2, 2022
Merged

Conversation

4144
Copy link
Contributor

@4144 4144 commented May 11, 2022

Pull Request Prelude

  • I have followed [proper Hercules code styling][code].
  • I have read and understood the [contribution guidelines][cont] before making this PR.
  • I am aware that this PR may be closed if the above-mentioned criteria are not fulfilled.

Changes Proposed

Update shuffle packets and keys up to 2022-05-18.
Update messages up to 2022-05-18.
Add script commands mes2, next2 (support in client still incomplete) (main 20220405+).
Add script commands for set npc dialog position: setdialogpos, setdialogpospercent (main 20220405+).
Add script command for set npc dialog size: setdialogsize (main 20220405+).
Extend script command playbgmall with type parameter (main 20220405+).
Add script command playbgmall2 same with playbgmall but with type parameter (main 20220405+).
Use item amount in packet ZC_INVENTORY_MOVE_FAILED.
Add term parameter into script command soundeffect.
Add script command soundeffectall2 same with soundeffectall but with term parameter (main 20220405+).
Use constants for play type in soundeffect and soundeffectall.
Fix repeat sound in packet PACKET_ZC_SOUND (script commands soundeffect, soundeffectall)
Update packet ZC_BROADCASTING_SPECIAL_ITEM_OBTAIN (for item obtain).
Update libbacktrace.
Update github ci configs.

@4144 4144 force-pushed the updatepackets branch from 386705e to 81d6e4d Compare May 11, 2022 19:22
doc/script_commands.txt Outdated Show resolved Hide resolved
@4144 4144 force-pushed the updatepackets branch 3 times, most recently from 95d2d1a to cd0f85b Compare May 18, 2022 16:54
@4144 4144 changed the title Update packets to 2022-05-04 Update packets to 2022-05-18 May 18, 2022
@4144 4144 force-pushed the updatepackets branch from 9fbc43a to b959985 Compare May 18, 2022 19:39
@MishimaHaruna MishimaHaruna added this to the Release v2022.06.01 milestone Jun 1, 2022
4144 and others added 26 commits June 2, 2022 04:45
Also add script command soundeffectall2 with term parameter.
Because before mode PLAY_SOUND_REPEAT was broken and worked as PLAY_SOUND_ONCE.
Look like false positives inside libconfig.
Also add enum with type values for packet ZC_BROADCASTING_SPECIAL_ITEM_OBTAIN
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants