Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CI #3118

Merged
merged 9 commits into from
Mar 3, 2022
Merged

Update CI #3118

merged 9 commits into from
Mar 3, 2022

Conversation

4144
Copy link
Contributor

@4144 4144 commented Feb 12, 2022

Pull Request Prelude

  • I have followed [proper Hercules code styling][code].
  • I have read and understood the [contribution guidelines][cont] before making this PR.
  • I am aware that this PR may be closed if the above-mentioned criteria are not fulfilled.

Changes Proposed

Update interfaces validation script.
Fixed some interfaces issues other issues added to ignore list for allow check only new issues.
Add ci builds with old gcc versions and some old clang versions.

@4144 4144 force-pushed the updateci branch 2 times, most recently from 2fd1098 to 58dd401 Compare February 12, 2022 14:58
@4144 4144 force-pushed the updateci branch 2 times, most recently from ca19f86 to 81443f1 Compare February 12, 2022 16:32
@@ -11991,7 +11991,7 @@ static int pc_read_attr_fix_db_entry(struct config_setting_t *def_attr, enum ele
int count = 0;
for (int i = 1; i <= 4; ++i) {
char name[5];
sprintf(name, "Lv%d", i);
safesnprintf(name, 5, "Lv%d", i);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh that's how it supposed to be :)

@MishimaHaruna MishimaHaruna added this to the Release v2022.03.02 milestone Mar 1, 2022
@MishimaHaruna MishimaHaruna merged commit 85ae843 into HerculesWS:master Mar 3, 2022
@4144 4144 deleted the updateci branch March 4, 2022 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants