-
Notifications
You must be signed in to change notification settings - Fork 759
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update CI #3118
Merged
Merged
Update CI #3118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4144
force-pushed
the
updateci
branch
2 times, most recently
from
February 12, 2022 14:58
2fd1098
to
58dd401
Compare
4144
force-pushed
the
updateci
branch
2 times, most recently
from
February 12, 2022 16:32
ca19f86
to
81443f1
Compare
MrKeiKun
reviewed
Feb 13, 2022
@@ -11991,7 +11991,7 @@ static int pc_read_attr_fix_db_entry(struct config_setting_t *def_attr, enum ele | |||
int count = 0; | |||
for (int i = 1; i <= 4; ++i) { | |||
char name[5]; | |||
sprintf(name, "Lv%d", i); | |||
safesnprintf(name, 5, "Lv%d", i); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oh that's how it supposed to be :)
MrKeiKun
approved these changes
Feb 13, 2022
MishimaHaruna
approved these changes
Mar 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Prelude
Changes Proposed
Update interfaces validation script.
Fixed some interfaces issues other issues added to ignore list for allow check only new issues.
Add ci builds with old gcc versions and some old clang versions.