Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Grade Enchant User Interface #3100

Merged
merged 1 commit into from
Jan 5, 2022

Conversation

Asheraf
Copy link
Contributor

@Asheraf Asheraf commented Dec 27, 2021

Pull Request Prelude

Changes Proposed

This PR adds support for Grade Enchanter.
image

The missing parts:

  • Values in the database are not official and I just guessed them.
  • Item protection for older clients is not supported

Issues addressed:

@Asheraf Asheraf added this to the Release v2022.01.05 milestone Dec 27, 2021
@Asheraf Asheraf force-pushed the grader branch 2 times, most recently from fff3ebb to 22aba9c Compare December 27, 2021 14:54
src/map/clif.c Show resolved Hide resolved
src/map/grader.c Show resolved Hide resolved
src/map/log.c Show resolved Hide resolved
src/map/grader.h Outdated Show resolved Hide resolved
Copy link
Member

@MishimaHaruna MishimaHaruna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also added the type '4' to the zenylog table since there's a pc->payzeny() call with the LOG_TYPE_GRADE type

@MishimaHaruna MishimaHaruna merged commit 092a0b1 into HerculesWS:master Jan 5, 2022
@Asheraf Asheraf deleted the grader branch March 4, 2022 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants