Fix permanent vacuum extreme status. #2995
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MrKeiKun
force-pushed
the
fix-extreme_vacuum
branch
from
3ad395e to
d142df0
Compare
MrKeiKun
changed the title
…imit so that the reduction won't exceed the max duration of the skill.
MrKeiKun
force-pushed
the
fix-extreme_vacuum
branch
from
d142df0 to
f9b2b58
Compare
4144
approved these changes
Apr 30, 2021
MishimaHaruna
approved these changes
May 3, 2021
3 tasks
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Prelude
Changes Proposed
This fixes vacuum extreme status gets permanent until you logout or die. This should force the max time reduction to 6.5 secs, vs before which exceed up to 18 secs(depends on target strength) when level 5 extreme vacuum only has 12 secs max duration.
Issues addressed: #2919