Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added new item bonuses #2970

Merged
merged 4 commits into from
Nov 2, 2021
Merged

Conversation

MrKeiKun
Copy link
Contributor

@MrKeiKun MrKeiKun commented Mar 28, 2021

Pull Request Prelude

Changes Proposed

Added the following item bonuses:

  • bonus bSubSkill
  • bonus2 bDropAddRace

Issues addressed:

src/map/battle.c Outdated Show resolved Hide resolved
src/map/battle.c Show resolved Hide resolved
src/map/battle.c Show resolved Hide resolved
@MrKeiKun MrKeiKun force-pushed the add-subskill branch 2 times, most recently from 7581d38 to e373006 Compare April 6, 2021 18:57
@MrKeiKun MrKeiKun changed the title Added item bonus bSubSkill. Added new item bonuses Apr 12, 2021
src/map/pc.c Outdated Show resolved Hide resolved
@MrKeiKun MrKeiKun force-pushed the add-subskill branch 2 times, most recently from 935f4c2 to 1881a22 Compare April 27, 2021 08:37
src/map/mob.c Outdated Show resolved Hide resolved
src/map/mob.c Outdated Show resolved Hide resolved
@MrKeiKun MrKeiKun force-pushed the add-subskill branch 4 times, most recently from a4d595c to 33e9ebd Compare September 9, 2021 05:59
@MrKeiKun MrKeiKun requested a review from MishimaHaruna October 6, 2021 11:57
src/map/mob.c Outdated Show resolved Hide resolved
doc/item_bonus.md Outdated Show resolved Hide resolved
src/map/mob.c Show resolved Hide resolved
@MishimaHaruna MishimaHaruna added the hacktoberfest-accepted Easy-to-tackle issues label Oct 6, 2021
@MishimaHaruna MishimaHaruna removed this from the Release v2021.10.06 milestone Oct 7, 2021
@MishimaHaruna MishimaHaruna added this to the Release v2021.11.03 milestone Oct 7, 2021
* PK Enabled, increased drop rate of each item by 25%
* Drop rate bonuses now stack with each other and capped to max of 90%
* Moved drop_rate0item on the end so it can override the existing drop_rate cap.
@MishimaHaruna MishimaHaruna merged commit fe2a683 into HerculesWS:master Nov 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hacktoberfest-accepted Easy-to-tackle issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants