Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Renewal Neutral Barrier Cooldown #2934

Merged
merged 1 commit into from
Jun 2, 2021
Merged

Renewal Neutral Barrier Cooldown #2934

merged 1 commit into from
Jun 2, 2021

Conversation

MrKeiKun
Copy link
Contributor

@MrKeiKun MrKeiKun commented Jan 17, 2021 •
edited
Loading

Pull Request Prelude

Changes Proposed

Renewal Neutral Barrier cooldown is based per level.
https://www.divine-pride.net/database/skill/2273

Issues addressed:

Asheraf
Asheraf requested changes Jan 18, 2021
View reviewed changes
Copy link
Contributor

@Asheraf Asheraf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your commit adds cooldown for NC_NEUTRALBARRIER while the message says it's for NC_MAGNETICFIELD which already has a cooldown per level. plus what source are you using for these changes.

@MrKeiKun MrKeiKun changed the title Renewal Magnetic Field Cooldown Renewal Neutral Barrier Cooldown Jan 19, 2021
@MrKeiKun MrKeiKun force-pushed the fix-magnetic_field_cd branch from 19f03b3 to dced4a5 Compare January 19, 2021 03:04
@MrKeiKun
Copy link
Contributor Author

Your commit adds cooldown for NC_NEUTRALBARRIER while the message says it's for NC_MAGNETICFIELD which already has a cooldown per level. plus what source are you using for these changes.

all most all renewal changes is based from kRO changes and database from Divine-Pride~

@MishimaHaruna MishimaHaruna added this to the Release v2021.06.02 milestone Jun 2, 2021
@MishimaHaruna MishimaHaruna merged commit 7022585 into HerculesWS:master Jun 2, 2021
@MrKeiKun MrKeiKun deleted the fix-magnetic_field_cd branch June 4, 2021 03:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Asheraf Asheraf Asheraf requested changes

@MishimaHaruna MishimaHaruna MishimaHaruna approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Release v2021.06.02
Development

Successfully merging this pull request may close these issues.
3 participants
@MrKeiKun @MishimaHaruna @Asheraf