Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make skills check if equipped ammunition type is appropriate for equipped weapon #2660

Merged
merged 2 commits into from
Apr 5, 2020

Conversation

Kenpachi2k13
Copy link
Member

@Kenpachi2k13 Kenpachi2k13 commented Mar 15, 2020

Pull Request Prelude

Changes Proposed

Liete mentioned that skills don't check if the equipped ammunition type is appropriate for equipped weapon and thus can be cast with wrong ammunition type equipped.

Liete
Hello.
Can anyone help me out with this issue:
I have set certain skill - Spread Shot to be working with grenade launchers, but there is a problem it uses both bullets and grenades be it shotgun or launcher equipped.

The actual problem is that you can equip bullets or grenades regardless of the equipped weapon type. This issue has already been reported: #2579
Since this needs some more information before completely get fixed this PR is a quick workaround for the time being.

Issues addressed: #2661, Partially #2579
Closes #2661

@Kenpachi2k13 Kenpachi2k13 added type:bug Issue is a bug or describes an incorrect behavior that should be fixed status:code-review Awaiting code review component:mechanics:skills Affecting the skills' game mechanics severity:4-high Crashes and general instability labels Mar 15, 2020
@Kenpachi2k13 Kenpachi2k13 added this to the Release v2020.04.05 milestone Mar 15, 2020
@Kenpachi2k13 Kenpachi2k13 self-assigned this Mar 15, 2020
Copy link
Contributor

@Asheraf Asheraf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wasn't this intended for example, an assassin is able to wear arrows and gain effects on Grimtooth, is that an athena thing or maybe pre-re thing? regardless I would like to have a battle conf for this one.

@Kenpachi2k13
Copy link
Member Author

Wasn't this intended for example, an assassin is able to wear arrows and gain effects on Grimtooth, is that an athena thing or maybe pre-re thing? regardless I would like to have a battle conf for this one.

This change doesn't affect Grimtooth+Arrows. Grimtooth doesn't have Requirements->AmmoTypes defined, so the changed code block is never reached. Thus there is no need for a battle flag.

@Kenpachi2k13 Kenpachi2k13 requested a review from Asheraf March 17, 2020 06:02
Copy link
Contributor

@Asheraf Asheraf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alright, thank you for clarifying that.

@Kenpachi2k13 Kenpachi2k13 linked an issue Mar 19, 2020 that may be closed by this pull request
@MishimaHaruna MishimaHaruna merged commit 02a84aa into HerculesWS:master Apr 5, 2020
@Kenpachi2k13 Kenpachi2k13 deleted the skill_check_ammo_type branch April 5, 2020 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:mechanics:skills Affecting the skills' game mechanics severity:4-high Crashes and general instability status:code-review Awaiting code review type:bug Issue is a bug or describes an incorrect behavior that should be fixed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use of wrong ammo with wrong weapon.
4 participants